Issue 270780043: Add method for getting ICMP latency from a host

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 270780043: Add method for getting ICMP latency from a host

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by bruce.yinhe.kth

Modified:
8 years, 6 months ago

Reviewers:
karthik.venkatesan85

CC:
fikri.firman, erneborg_kth.se, mfalgert_kth.se, byi_kth.se, kgve_kth.se, kirillb_kth.se, dmk_kth.se, teowey

Visibility:
Public.

More Reviews

Description

Add method for getting ICMP latency from a host

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -0 lines)			Patch
	M	src/main/java/se/kth/crypt/server/core/SolicitationReceiver.java	View		2 chunks	+50 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruce.yinhe.kth

In order to elect the master node, the latency is one of the contributing factors. ...

8 years, 6 months ago (2015-10-11 22:21:54 UTC) #1

karthik.venkatesan85

8 years, 6 months ago (2015-10-12 08:17:07 UTC) #2

https://codereview.appspot.com/270780043/diff/1/src/main/java/se/kth/crypt/se...
File src/main/java/se/kth/crypt/server/core/SolicitationReceiver.java (right):

https://codereview.appspot.com/270780043/diff/1/src/main/java/se/kth/crypt/se...
src/main/java/se/kth/crypt/server/core/SolicitationReceiver.java:32: String
command = "ping -c 1 " + IPAddress;
1.Is it possible to have a switch statement to handle all different OS like
MAC,Windows and Linux?
2.How would the error connectivity issues during ICMP ping handled using try
catch?--->Asking this for my learning purpose

Expand All Messages | Collapse All Messages