Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3840)

Issue 270560043: i#1734: Create Dr. Fuzz: fix print_target_buffer bug

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by zhaoqin
Modified:
8 years, 6 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1734: Create Dr. Fuzz: fix print_target_buffer bug - terminate printing if (buffer_size - *sofar) < 2*MAX_PRINT_PER_ITERATION ---------------

Patch Set 1 #

Total comments: 2

Patch Set 2 : PTAL #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M drmemory/fuzzer.c View 1 2 1 chunk +19 lines, -10 lines 0 comments Download

Messages

Total messages: 5
zhaoqin
8 years, 6 months ago (2015-10-29 18:41:24 UTC) #1
bruening
https://codereview.appspot.com/270560043/diff/1/drmemory/fuzzer.c File drmemory/fuzzer.c (right): https://codereview.appspot.com/270560043/diff/1/drmemory/fuzzer.c#newcode352 drmemory/fuzzer.c:352: #define MAX_PRINT_PER_ITERATION 0x10 /* xx\nNOTE: ...\0 */ Why in ...
8 years, 6 months ago (2015-10-29 19:51:40 UTC) #2
zhaoqin
Commit log for latest patchset: --------------- i#1734: Create Dr. Fuzz: fix print_target_buffer bug - stop ...
8 years, 6 months ago (2015-10-29 20:49:50 UTC) #3
bruening
LGTM Ideally there would be a test that hits the limit
8 years, 6 months ago (2015-10-29 21:03:17 UTC) #4
zhaoqin
8 years, 6 months ago (2015-10-30 19:23:22 UTC) #5
Committed as
https://github.com/DynamoRIO/drmemory/commit/8a1bb53356bdf61dad624530bf20c544...

Final commit log: 
---------------
i#1734: Create Dr. Fuzz: fix print_target_buffer bug

- stop printing if cannot print a full new line

Review-URL: https://codereview.appspot.com/270560043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b