Run "svn status" for "gclient runhooks" and "gclient status" with an absolute
path to the working copy for consistency with how "gclient sync" runs
"svn checkout" and "svn update".
We wanted to change the Chromium GYP hook to be triggered when any file in ...
15 years, 1 month ago
(2009-03-12 18:14:23 UTC)
#1
We wanted to change the Chromium GYP hook to be triggered when any file in
src/tools/gyp changes. The idea was to add src/tools/gyp to the hook's pattern.
This works fine for "gclient sync" operations because sync always runs "svn
update" and "svn checkout" with an absolute path to the working copy. It does
not work for "gclient runhooks" because runhooks (and stat) relies on changing
to the working copy directory and running "svn status" instead of passing svn an
absolute path to the working copy. For consistency, we should invoke "svn
status" the same way that we invoke "svn checkout" and "svn update", with
absolute paths to the working copy. This will allow us to reliably call the GYP
hook when local changes to GYP are made and someone runs "gclient runhooks".
Issue 27043: Run "svn status" for "gclient runhooks" and "gclient status" with an absolute...
Created 15 years, 1 month ago by Mark Mentovai
Modified 15 years ago
Reviewers: M-A, thomasvl
Base URL: http://gclient.googlecode.com/svn/trunk/
Comments: 0