Add updating node latency value to schedule tasks

Add updating node latency value to schedule tasks

[bruce.yinhe.kth, 2015-10-18 22:18:42]

Add updating node latency value to schedule tasks

[robert.erneborg, 2015-10-19 19:31:41]

https://codereview.appspot.com/269510043/diff/1/src/main/java/se/kth/crypt/se...
File src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java (right):

https://codereview.appspot.com/269510043/diff/1/src/main/java/se/kth/crypt/se...
src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java:55: }
overall looks great. I have two questions/suggestions though. Provided the node
is connected to a great amount of peer nodes this might take a lot of time:
could this maybe be made concurrent? Also we discussed this earlier but it might
be a good idea to exclude the first ping and calculate the average of the
following 2-3 pings since the first ping might be slower because of the openflow
switches.

Last but not least, you should consider setting a upper limit for the ping, i.e.
timeout in case the server is down (1-2 seconds should suffice).

[byi_kth.se, 2015-10-19 22:00:38]

Good advice. We can use the @Asynchronous
<https://docs.oracle.com/javaee/6/tutorial/doc/gkkqg.html> annotation from
javax.ejb.Asynchronous (that would require Java EE 6)

On Mon, Oct 19, 2015 at 9:31 PM, <robert.erneborg@gmail.com> wrote:

>
>
>
https://codereview.appspot.com/269510043/diff/1/src/main/java/se/kth/crypt/se...
> File src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java
> (right):
>
>
>
https://codereview.appspot.com/269510043/diff/1/src/main/java/se/kth/crypt/se...
> src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java:55: }
> overall looks great. I have two questions/suggestions though. Provided
> the node is connected to a great amount of peer nodes this might take a
> lot of time: could this maybe be made concurrent? Also we discussed this
> earlier but it might be a good idea to exclude the first ping and
> calculate the average of the following 2-3 pings since the first ping
> might be slower because of the openflow switches.
>
> Last but not least, you should consider setting a upper limit for the
> ping, i.e. timeout in case the server is down (1-2 seconds should
> suffice).
>
> https://codereview.appspot.com/269510043/
>

[marcus.falgert, 2015-10-20 13:09:02]

https://codereview.appspot.com/269510043/diff/1/src/main/java/se/kth/crypt/se...
File src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java (right):

https://codereview.appspot.com/269510043/diff/1/src/main/java/se/kth/crypt/se...
src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java:51:
for(Map.Entry<String, CryptRabbitTemplate> entry :
remoteRabbitConnections.entrySet()) {
Looks good!