Issue 269310044: Bug1214829

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 269310044: Bug1214829

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by franziskus

Modified:
10 years, 8 months ago

Reviewers:
ekr, mt

Visibility:
Public.

More Reviews

Description

[CID 749513] leaked_storage: Variable filename going out of scope leaks the storage it points to

Patch Set 3 : #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	lib/softoken/pkcs11.c	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

https://codereview.appspot.com/269310044/diff/20001/lib/softoken/pkcs11.c File lib/softoken/pkcs11.c (right): https://codereview.appspot.com/269310044/diff/20001/lib/softoken/pkcs11.c#newcode2764 lib/softoken/pkcs11.c:2764: rvstr = NULL; This shouldn't be necessary, since rvstr ...

10 years, 8 months ago (2015-10-16 03:14:04 UTC) #1

franziskus

10 years, 8 months ago (2015-10-16 16:14:24 UTC) #2

On 2015/10/16 03:14:04, mt wrote:
> https://codereview.appspot.com/269310044/diff/20001/lib/softoken/pkcs11.c
> File lib/softoken/pkcs11.c (right):
> 
>
https://codereview.appspot.com/269310044/diff/20001/lib/softoken/pkcs11.c#new...
> lib/softoken/pkcs11.c:2764: rvstr = NULL;
> This shouldn't be necessary, since rvstr has to be NULL to get pass the check
on
> line 2746.

rvstr is actually always NULL when we jump to loser (that switch statement is
unreadable with those indentations... we need clang-format fast)

Expand All Messages | Collapse All Messages