Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(787)

Issue 268740044: Issue 4594: Rewrite Multi_measure_rest_engraver to improve clarity. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by Dan Eble
Modified:
8 years, 7 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

In the process of trying to understand the mmrest engraver, I rewrote lots of it. It still works the same according to the regression tests, but I've eliminated some state, factored out some functions, renamed some variables, tweaked some logic, etc.

Patch Set 1 : comments, naming, style #

Patch Set 2 : move most processing into process_music() #

Patch Set 3 : simplify logic (the interesting part) #

Patch Set 4 : rearrange for readability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -143 lines) Patch
M lily/multi-measure-rest-engraver.cc View 1 2 3 4 chunks +131 lines, -143 lines 0 comments Download

Messages

Total messages: 7
Dan Eble
8 years, 7 months ago (2015-09-06 00:03:41 UTC) #1
Dan Eble
On 2015/09/06 00:03:41, Dan Eble wrote: To prospective reviewers: I'm sorry this is such a ...
8 years, 7 months ago (2015-09-06 13:28:02 UTC) #2
Dan Eble
comments, naming, style
8 years, 7 months ago (2015-09-06 18:45:31 UTC) #3
Dan Eble
move most processing into process_music()
8 years, 7 months ago (2015-09-06 18:46:30 UTC) #4
Dan Eble
simplify logic (the interesting part)
8 years, 7 months ago (2015-09-06 18:47:49 UTC) #5
Dan Eble
rearrange for readability
8 years, 7 months ago (2015-09-06 18:48:52 UTC) #6
Dan Eble
8 years, 7 months ago (2015-09-06 18:51:55 UTC) #7
Reviewers, I tried to concentrate the real changes in patch set 3.  TIA.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b