Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7633)

Issue 2687: Support for internal SVN servers and patch sets based in explicit revision range

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by Janusz
Modified:
3 months, 2 weeks ago
Reviewers:
CC:
michal.michalec_gmail.com
Base URL:
http://rietveld.googlecode.com/svn/trunk/static/
Visibility:
Public.

Description

I'm trying to add support for SVN repositories ran on local networks with the ability to upload base files different than BASE, give the ability to review changes made between two explicit revisions. For eg.: upload.py -l -- -r 8937:8938

Patch Set 1 #

Patch Set 2 : Unused varable deleted #

Patch Set 3 : Support for files added in the given revision range #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
upload.py View 1 2 5 chunks +18 lines, -10 lines 1 comment Download

Messages

Total messages: 3
Janusz
Hi, I have prepared a change enabling to send revision based diffs. Please see if ...
15 years, 7 months ago (2008-07-28 21:13:21 UTC) #1
GvR
I'm sorry, you need to find someone else to review this first. Maybe ask on ...
15 years, 7 months ago (2008-07-30 20:44:43 UTC) #2
Janusz
15 years, 7 months ago (2008-08-02 14:01:16 UTC) #3
http://codereview.appspot.com/2687/diff/28/4
File upload.py (right):

http://codereview.appspot.com/2687/diff/28/4#newcode598
Line 598: if status and (status[0] == "A" or not revisions.has_key(filename) or
revisions[filename] == "0"):
Solves a problem when file was added in the given revision range.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b