Issue 268630044: i#1812 pattern mode on TLS refs: skip checks for app TLS reference

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 268630044: i#1812 pattern mode on TLS refs: skip checks for app TLS reference

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 5 months ago by zhaoqin

Modified:
8 years, 5 months ago

Reviewers:
bruening

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1812 pattern mode on TLS refs: skip checks for app TLS reference - return false in pattern_opnd_needs_check on TLS reference ---------------

Patch Set 3 : Committed #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	drmemory/pattern.c	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bruening

It is DRi#1812, not DrMem. There are also several grammar errors.

8 years, 5 months ago (2015-11-06 03:23:53 UTC) #2

bruening

On Thu, Nov 5, 2015 at 10:23 PM, <bruening@google.com> wrote: > It is DRi#1812, not ...

8 years, 5 months ago (2015-11-06 03:24:59 UTC) #3

zhaoqin

Commit log for latest patchset: --------------- i#1812 pattern mode on TLS refs: skip checks for ...

8 years, 5 months ago (2015-11-06 16:24:40 UTC) #4

bruening

LGTM https://codereview.appspot.com/268630044/diff/20001/drmemory/pattern.c File drmemory/pattern.c (right): https://codereview.appspot.com/268630044/diff/20001/drmemory/pattern.c#newcode77 drmemory/pattern.c:77: * To check an app TLS accesses, we ...

8 years, 5 months ago (2015-11-06 17:54:58 UTC) #5

zhaoqin

8 years, 5 months ago (2015-11-08 03:44:12 UTC) #6

Committed as
https://github.com/DynamoRIO/drmemory/commit/ab12f1781b8433dfab5a8b5de2fd4de2...

Final commit log: 
---------------
i#1812 pattern mode on TLS refs: skip checks for app TLS accesses

- return false for app TLS access operands in pattern_opnd_needs_check

Review-URL: https://codereview.appspot.com/268630044
---------------

Expand All Messages | Collapse All Messages