Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4460)

Issue 2686041: doc additions power chords (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Carl
Modified:
13 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

doc additions power chords additions to fretted-strings.itely description and examples for the use of the new command \powerChords addition of two new modifiers to notation-appendices.itely power chord symbol Added power chord definition, symbol and command to typeset this symbol.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix lilypond indentation #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -7 lines) Patch
M Documentation/notation/fretted-strings.itely View 1 6 chunks +85 lines, -5 lines 2 comments Download
M Documentation/notation/notation-appendices.itely View 2 chunks +29 lines, -2 lines 0 comments Download
M ly/chord-modifiers-init.ly View 2 chunks +8 lines, -0 lines 0 comments Download
M ly/property-init.ly View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Carl
Patrick Schmidt has added two- and three-note power chords to the known set of chord ...
13 years, 6 months ago (2010-10-23 00:07:44 UTC) #1
Graham Percival (old account)
Looks mostly fine. http://codereview.appspot.com/2686041/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/2686041/diff/1/Documentation/notation/fretted-strings.itely#newcode1416 Documentation/notation/fretted-strings.itely:1416: \clef "treble_8" None of these lines ...
13 years, 6 months ago (2010-10-23 01:30:43 UTC) #2
Carl
On 2010/10/23 01:30:43, Graham Percival wrote: > Looks mostly fine. > Fixed all of these, ...
13 years, 6 months ago (2010-10-23 02:47:45 UTC) #3
Graham Percival (old account)
LGTM, go ahead and push. http://codereview.appspot.com/2686041/diff/5001/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/2686041/diff/5001/Documentation/notation/fretted-strings.itely#newcode1422 Documentation/notation/fretted-strings.itely:1422: g-\rightHandFinger #3 c-\rightHandFinger #4 ...
13 years, 6 months ago (2010-10-23 05:30:24 UTC) #4
Trevor Daniels
LGTM, but we should add power chords to the glossary and reference it from the ...
13 years, 6 months ago (2010-10-23 05:56:16 UTC) #5
Valentin Villenave
13 years, 6 months ago (2010-10-23 08:42:09 UTC) #6
On 2010/10/23 05:56:16, Trevor Daniels wrote:
> LGTM, but we should add power chords to the glossary and reference it from the
> @seealso.

To whomever pushes this patch: please remember to update
http://code.google.com/p/lilypond/issues/detail?id=1315 accordingly :-)

Cheers,
Valentin
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b