Issue 268400043: Bug1213980

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 268400043: Bug1213980

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by franziskus

Modified:
8 years, 6 months ago

Reviewers:
ekr, mt

Visibility:
Public.

More Reviews

Description

[CID 1286127] Variable objects going out of scope leaks the storage it points to If create_object_array fails, we have to free the objects variable.

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	lib/dev/devutil.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM https://codereview.appspot.com/268400043/diff/1/lib/dev/devutil.c File lib/dev/devutil.c (right): https://codereview.appspot.com/268400043/diff/1/lib/dev/devutil.c#newcode582 lib/dev/devutil.c:582: nss_ZFreeIf(objects); nit: indent looks whacky

8 years, 6 months ago (2015-10-13 18:04:14 UTC) #1

franziskus

8 years, 6 months ago (2015-10-13 22:29:35 UTC) #2

On 2015/10/13 18:04:14, mt wrote:
> LGTM
> 
> https://codereview.appspot.com/268400043/diff/1/lib/dev/devutil.c
> File lib/dev/devutil.c (right):
> 
> https://codereview.appspot.com/268400043/diff/1/lib/dev/devutil.c#newcode582
> lib/dev/devutil.c:582: nss_ZFreeIf(objects);
> nit: indent looks whacky

yeah, tabs and space... should be better now

Expand All Messages | Collapse All Messages