Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(389)

Issue 268050045: Create \= command for setting spanner-id (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by dak
Modified:
8 years, 5 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Create \= command for setting spanner-id Also contains commits: NR: document \= in slur sections Make some regtests use \= instead of their own definitions

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M Documentation/learning/common-notation.itely View 1 chunk +2 lines, -3 lines 0 comments Download
M Documentation/notation/expressive.itely View 2 chunks +15 lines, -4 lines 4 comments Download
M input/regression/phrasing-slur-multiple.ly View 2 chunks +3 lines, -7 lines 0 comments Download
M input/regression/slur-multiple.ly View 2 chunks +3 lines, -7 lines 0 comments Download
M ly/spanners-init.ly View 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 3
thomasmorley651
LGTM Some nitpicks: https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely#newcode724 Documentation/notation/expressive.itely:724: them with @code{\=} followed by an ...
8 years, 6 months ago (2015-10-04 00:45:36 UTC) #1
dak
https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely#newcode724 Documentation/notation/expressive.itely:724: them with @code{\=} followed by an identifying number or ...
8 years, 6 months ago (2015-10-04 03:58:31 UTC) #2
Trevor Daniels
8 years, 6 months ago (2015-10-08 12:01:14 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b