Issue 267560043: Concurrently execute pings. Detecting OS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 267560043: Concurrently execute pings. Detecting OS

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by bruce.yinhe.kth

Modified:
8 years, 3 months ago

Reviewers:
karthik.venkatesan85, robert.erneborg

CC:
robert.erneborg, teowey, marcus.falgert, fikri.firman, bruce.yinhe, dkostic, karthik.venkatesan85

Visibility:
Public.

More Reviews

Description

Concurrently execute pings. Detecting OS

Patch Set 1 #

Total comments: 3

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -68 lines)			Patch
M	src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java	View	3 chunks	+28 lines, -4 lines	1 comment	Download
A +	src/main/java/se/kth/crypt/server/core/PingCaller.java	View	1 chunk	+29 lines, -8 lines	2 comments	Download
D	src/main/java/se/kth/crypt/server/util/CryptUtils.java	View	1 chunk	+0 lines, -56 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bruce.yinhe.kth

Concurrently executing pings. @robert Able to detect OS. @karthik Using Java FutureTask http://docs.oracle.com/javase/1.5.0/docs/api/java/util/concurrent/FutureTask.html

8 years, 6 months ago (2015-10-25 02:15:30 UTC) #1

robert.erneborg

https://codereview.appspot.com/267560043/diff/1/src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java File src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java (right): https://codereview.appspot.com/267560043/diff/1/src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java#newcode79 src/main/java/se/kth/crypt/server/core/CryptScheduledTasks.java:79: looking forward to test this properly! :) https://codereview.appspot.com/267560043/diff/1/src/main/java/se/kth/crypt/server/core/PingCaller.java File ...

8 years, 6 months ago (2015-10-25 15:24:07 UTC) #2

karthik.venkatesan85

https://codereview.appspot.com/267560043/diff/1/src/main/java/se/kth/crypt/server/core/PingCaller.java File src/main/java/se/kth/crypt/server/core/PingCaller.java (right): https://codereview.appspot.com/267560043/diff/1/src/main/java/se/kth/crypt/server/core/PingCaller.java#newcode36 src/main/java/se/kth/crypt/server/core/PingCaller.java:36: else if (OS.indexOf("mac") >= 0) looks fine.....Is this possible ...

8 years, 6 months ago (2015-10-26 09:46:15 UTC) #3

Expand All Messages | Collapse All Messages