Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1191)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
267500043
: policy_define
Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by
dukehc13
Modified:
8 years, 4 months ago
Reviewers:
CC:
chenghu_kth.se
Base URL:
git@gits-14.sys.kth.se:nkoutsou/NSC.git@codereview
Visibility:
Public.
More Reviews
Description
policy_define BUG=
Patch Set 1
#
Patch Set 2 :
#
Patch Set 3 :
#
Patch Set 4 :
#
Patch Set 5 :
#
Patch Set 6 :
#
Patch Set 7 :
#
Patch Set 8 :
#
Patch Set 9 :
#
Patch Set 10 :
#
Patch Set 11 :
#
Patch Set 12 :
#
Patch Set 13 :
#
Patch Set 14 :
#
Patch Set 15 :
#
Patch Set 16 :
#
Patch Set 17 :
#
Patch Set 18 :
#
Patch Set 19 :
#
Patch Set 20 :
#
Patch Set 21 :
#
Patch Set 22 :
#
Patch Set 23 :
#
Patch Set 24 :
#
Patch Set 25 :
#
Patch Set 26 :
#
Patch Set 27 :
#
Created:
8 years, 4 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+56 lines, -27 lines
)
Patch
A
new/1.json
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+14 lines, -0 lines
0 comments
Download
A +
new/LOGO.png
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
Binary file
0 comments
Download
A +
new/nf_policies.html
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
6 chunks
+11 lines, -22 lines
0 comments
Download
A
new/p.txt
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+3 lines, -0 lines
0 comments
Download
A +
new/policy_define.py
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
5 chunks
+6 lines, -6 lines
0 comments
Download
A +
new/ryu.topology.css
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
0 chunks
+-1 lines, --1 lines
0 comments
Download
A +
new/ryu.topology.js
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
0 chunks
+-1 lines, --1 lines
0 comments
Download
A
new/table.html
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+1 line, -0 lines
0 comments
Download
A
new/test.html
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+22 lines, -0 lines
0 comments
Download
M
nsc_topology/policy_define.py
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+1 line, -1 line
0 comments
Download
Issue 267500043: policy_define
Created 8 years, 6 months ago by dukehc13
Modified 8 years, 4 months ago
Reviewers:
Base URL: git@gits-14.sys.kth.se:nkoutsou/NSC.git@codereview
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
