Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 26740043: After deploying a bundle increment counter.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by bac
Modified:
5 years, 10 months ago
Reviewers:
mp+195317, frankban
Visibility:
Public.

Description

After deploying a bundle increment counter. The guiserver will make a GET request to the deployment counter incrementer URL for the bundle. This required accepting the bundle ID in the Deployer/Import path. Note neither the GUI nor quickstart have been updated to pass this value yet. The charmworldurl is also now passed to the server via the command line. QA: just deploy your favorite bundle and see that it works as it should. You can observe the bundle page in charmworld and see the counts remain at 0. https://code.launchpad.net/~bac/charms/precise/juju-gui/increment-deployments/+merge/195317 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 35

Patch Set 2 : After deploying a bundle increment counter. #

Total comments: 2

Patch Set 3 : After deploying a bundle increment counter. #

Patch Set 4 : After deploying a bundle increment counter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -43 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M config/guiserver.conf.template View 1 chunk +1 line, -0 lines 0 comments Download
M hooks/backend.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M hooks/utils.py View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M server/guiserver/apps.py View 1 chunk +2 lines, -1 line 0 comments Download
M server/guiserver/bundles/__init__.py View 1 1 chunk +8 lines, -2 lines 0 comments Download
M server/guiserver/bundles/base.py View 1 2 7 chunks +19 lines, -7 lines 0 comments Download
M server/guiserver/bundles/utils.py View 1 2 chunks +43 lines, -0 lines 0 comments Download
M server/guiserver/bundles/views.py View 4 chunks +15 lines, -7 lines 0 comments Download
M server/guiserver/manage.py View 1 chunk +4 lines, -0 lines 0 comments Download
M server/guiserver/tests/bundles/test_base.py View 1 2 3 13 chunks +95 lines, -14 lines 0 comments Download
M server/guiserver/tests/bundles/test_utils.py View 1 3 chunks +79 lines, -0 lines 0 comments Download
M server/guiserver/tests/bundles/test_views.py View 1 2 chunks +28 lines, -1 line 0 comments Download
M server/runserver.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/test_backends.py View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M tests/test_utils.py View 1 2 5 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
5 years, 10 months ago (2013-11-14 21:52:11 UTC) #1
frankban
This branch looks very nice Brad. LGTM with changes. I added a lot of comments ...
5 years, 10 months ago (2013-11-15 08:48:20 UTC) #2
bac
Please take a look. https://codereview.appspot.com/26740043/diff/1/server/guiserver/apps.py File server/guiserver/apps.py (right): https://codereview.appspot.com/26740043/diff/1/server/guiserver/apps.py#newcode43 server/guiserver/apps.py:43: options.charmworldurl) Good idea but I'd ...
5 years, 10 months ago (2013-11-15 12:45:10 UTC) #3
frankban
Just one more comment, I'll QA asap. https://codereview.appspot.com/26740043/diff/20001/server/guiserver/bundles/base.py File server/guiserver/bundles/base.py (right): https://codereview.appspot.com/26740043/diff/20001/server/guiserver/bundles/base.py#newcode188 server/guiserver/bundles/base.py:188: if bundle_id ...
5 years, 10 months ago (2013-11-15 14:42:03 UTC) #4
bac
5 years, 10 months ago (2013-11-15 18:51:47 UTC) #5
*** Submitted:

After deploying a bundle increment counter.

The guiserver will make a GET request to the deployment counter incrementer
URL for the bundle.  This required accepting the bundle ID in the
Deployer/Import path.

Note neither the GUI nor quickstart have been updated to pass this value yet.

The charmworldurl is also now passed to the server via the command line.

QA: just deploy your favorite bundle and see that it works as it should.  You
can observe the bundle page in charmworld and see the counts remain at 0.

R=frankban
CC=
https://codereview.appspot.com/26740043

https://codereview.appspot.com/26740043/diff/20001/server/guiserver/bundles/b...
File server/guiserver/bundles/base.py (right):

https://codereview.appspot.com/26740043/diff/20001/server/guiserver/bundles/b...
server/guiserver/bundles/base.py:188: if bundle_id is not None and error is
None:
On 2013/11/15 14:42:03, frankban wrote:
> I the future has been cancelled then error is not defined here.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b