Issue 266820043: Add support for ASan builds on Linux

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 266820043: Add support for ASan builds on Linux

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by twsmith

Modified:
8 years, 8 months ago

Reviewers:
ekr

Visibility:
Public.

More Reviews

Patch Set 2 : Patch Set 2 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -5 lines)			Patch
	M	Makefile	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	coreconf/Linux.mk	View	1	3 chunks	+25 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ekr-rietveld

https://codereview.appspot.com/266820043/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/266820043/diff/1/Makefile#newcode83 Makefile:83: NSPR_COMPILERS += CFLAGS+='-fsanitize=address -fno-omit-frame-pointer' LDFLAGS+='-fsanitize=address' This should be two ...

8 years, 8 months ago (2015-09-09 21:05:48 UTC) #1

twsmith

8 years, 8 months ago (2015-09-09 22:33:51 UTC) #2

On 2015/09/09 21:05:48, ekr-webrtc wrote:
> https://codereview.appspot.com/266820043/diff/1/Makefile
> File Makefile (right):
> 
> https://codereview.appspot.com/266820043/diff/1/Makefile#newcode83
> Makefile:83: NSPR_COMPILERS += CFLAGS+='-fsanitize=address
> -fno-omit-frame-pointer' LDFLAGS+='-fsanitize=address'
> This should be two separate lines.
Fixed.

> Also, it's going to choke if you have CC = gcc, so don't you want to set
> something to clang
Fixed.

 
> https://codereview.appspot.com/266820043/diff/1/coreconf/Linux.mk
> File coreconf/Linux.mk (right):
> 
> https://codereview.appspot.com/266820043/diff/1/coreconf/Linux.mk#newcode142
> coreconf/Linux.mk:142: endif
> Why do you need to do this in both OS_CFLAGS and LDFLAGS and NSPR_<foo
> >
This is for the NSS build the NSPR_<foo> is for the NSPR build.

Expand All Messages | Collapse All Messages