Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1795)

Issue 26550043: Fix handling of deprecated tools-url (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by wallyworld
Modified:
10 years, 5 months ago
Reviewers:
jameinel, mp+195201
Visibility:
Public.

Description

Fix handling of deprecated tools-url The branch ensures that regardless of which combination of tools-url and tool-metadata-url values are in the environment.yaml, the constructed config struct has both tools-url and tools-metadata-url attributes, both of which are set to the first non-empty value of, in order of precedence: 1. tools-metadata-url 2. tools-url This ensures the config passed to older nodes during an upgrade still contains the older tools-url that those nodes rely on. https://code.launchpad.net/~wallyworld/juju-core/upgrade-fix-tools-url/+merge/195201 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/config/config.go View 1 chunk +3 lines, -1 line 0 comments Download
M environs/config/config_test.go View 4 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 2
wallyworld
Please take a look.
10 years, 5 months ago (2013-11-14 11:05:25 UTC) #1
jameinel
10 years, 5 months ago (2013-11-14 11:11:05 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b