Issue 26540043: Update the quickstart test venv set up process.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26540043: Update the quickstart test venv set up process.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by frankban

Modified:
10 years, 6 months ago

Reviewers:
mp+195200, gary.poster

Visibility:
Public.

Description

Update the quickstart test venv set up process. Remove the activate file if the requirements installation process fails. Also updated the default GUI charm URL, and the documentation. https://code.launchpad.net/~frankban/juju-quickstart/improve-venv/+merge/195200 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update the quickstart test venv set up process. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -11 lines)			Patch
M	HACKING.rst	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	MANIFEST.in	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	Makefile	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/settings.py	View		1 chunk	+1 line, -1 line	0 comments	Download
A	requirements.pip	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	setup.py	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	test-requirements.pip	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

Nice. LGTM with trivial comments. https://codereview.appspot.com/26540043/diff/1/HACKING.rst File HACKING.rst (right): https://codereview.appspot.com/26540043/diff/1/HACKING.rst#newcode97 HACKING.rst:97: Also ensure, before updating ...

10 years, 6 months ago (2013-11-14 12:04:01 UTC) #2

frankban

10 years, 6 months ago (2013-11-14 12:36:27 UTC) #3

*** Submitted:

Update the quickstart test venv set up process.

Remove the activate file if the requirements
installation process fails.

Also updated the default GUI charm URL, and
the documentation.

R=gary.poster
CC=
https://codereview.appspot.com/26540043

https://codereview.appspot.com/26540043/diff/1/HACKING.rst
File HACKING.rst (right):

https://codereview.appspot.com/26540043/diff/1/HACKING.rst#newcode97
HACKING.rst:97: Also ensure, before updating the application dependencies, that
those packages
On 2013/11/14 12:04:01, gary.poster wrote:
> I suggest that you make this a second paragraph, since it is a separate topic.

Done.

https://codereview.appspot.com/26540043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/26540043/diff/1/Makefile#newcode27
Makefile:27: (rm -f $(VENV_ACTIVATE); exit 1)
On 2013/11/14 12:04:01, gary.poster wrote:
> same comment as with gui charm: instead of rm'ing, let's touch
> test-requirements.pip.

Done.

Expand All Messages | Collapse All Messages