Issue 265030043: Add circle.yml file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 265030043: Add circle.yml file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 7 months ago by ekr-rietveld

Modified:
7 years, 8 months ago

Reviewers:
mt

Visibility:
Public.

More Reviews

Description

Add circle.yml file

Patch Set 1 #

Total comments: 3

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	A	circle.yml	View		1 chunk	+22 lines, -0 lines	3 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

8 years, 7 months ago (2015-09-03 17:27:08 UTC) #2

LGTM

https://codereview.appspot.com/265030043/diff/1/circle.yml
File circle.yml (right):

https://codereview.appspot.com/265030043/diff/1/circle.yml#newcode1
circle.yml:1: checkout:
Meta: is circle ok with a .circle.yml file?  That might be a better choice here.

https://codereview.appspot.com/265030043/diff/1/circle.yml#newcode3
circle.yml:3: - (cd ..; hg clone https://hg.mozilla.org/projects/nspr)
Are the parentheses necessary?  I'd have thought not based on below.

https://codereview.appspot.com/265030043/diff/1/circle.yml#newcode9
circle.yml:9: #        - cd tests; ./all.sh
Don't include commented out code.

Expand All Messages | Collapse All Messages