Issue 264740043: TBR: i#1732 drcpusim: add library blacklist

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 264740043: TBR: i#1732 drcpusim: add library blacklist

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by bruening

Modified:
10 years, 10 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1732 drcpusim: add library blacklist Adds a new option -blacklist which takes a :-separate listed of library names in which errors should be ignored. The default on Windows is "ntdll.dll" to avoid rdrand on Windows 10 ntdll!RtlpHeapGenerateRandomValue32. Updates the output to list the library and offset rather than an absolute PC. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -10 lines)			Patch
M	clients/drcpusim/drcpusim.cpp	View	4 chunks	+38 lines, -3 lines	0 comments	Download
M	clients/drcpusim/options.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	clients/drcpusim/options.cpp	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	clients/drcpusim/tests/mmx.templatex	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcpusim/tests/sse.templatex	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcpusim/tests/sse2.templatex	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcpusim/tests/sse3.templatex	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcpusim/tests/sse41.templatex	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcpusim/tests/sse42.templatex	View	1 chunk	+1 line, -1 line	0 comments	Download
M	clients/drcpusim/tests/ssse3.templatex	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

10 years, 10 months ago (2015-08-20 03:41:27 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/23531a54ea2c72c6e34a2a3e88e9a83...

Final commit log: 
---------------
i#1732 drcpusim: add library blacklist

Adds a new option -blacklist which takes a :-separate listed of
library names in which errors should be ignored.  The default on
Windows is "ntdll.dll" to avoid rdrand on Windows 10
ntdll!RtlpHeapGenerateRandomValue32.

Updates the output to list the library and offset rather than an
absolute PC.

Review-URL: https://codereview.appspot.com/264740043
---------------

Expand All Messages | Collapse All Messages