i#1785: drinject should fail if app is not reg: return false if no config found

Commit log for first patchset:
---------------
i#1785: drinject should fail if app is not reg: return false if no config found

- return false in dr_inject_process_inject if no config for app is found
---------------

[bruening, 2015-10-05 20:57:45]

https://codereview.appspot.com/264670043/diff/1/core/win32/injector.c
File core/win32/injector.c (right):

https://codereview.appspot.com/264670043/diff/1/core/win32/injector.c#newcode856
core/win32/injector.c:856: return false;
This solution leaves the reader wondering why the inject var is set.  It is also
not symmetric with all the error cases above.  I would vote for my earlier
suggestion of moving lines 844:845 (if (!inject)) down to line 860 after this if
block.

[zhaoqin, 2015-10-05 21:36:16]

Commit log for latest patchset:
---------------
i#1785: drinject should fail if app is not reg: return false if no config found

- return false in dr_inject_process_inject if no config for app is found

FIXED#1785

Review-URL: https://codereview.appspot.com/264670043
---------------

[bruening, 2015-10-05 21:37:49]

On 2015/10/05 21:36:16, zhaoqin wrote:
> FIXED#1785

This seems odd

[zhaoqin, 2015-10-05 21:40:00]

Commit log for latest patchset:
---------------
i#1785: drinject should fail if app is not reg: return false if no config found

- return false in dr_inject_process_inject if no config for app is found

Fixes #1785

Review-URL: https://codereview.appspot.com/264670043
---------------

[bruening, 2015-10-05 21:49:14]

LGTM

[zhaoqin, 2015-10-05 22:02:39]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/b205528fecff352356cdab251381959...

Final commit log: 
---------------
i#1785: drinject should fail if app is not reg: return false if no config found

- return false in dr_inject_process_inject if no config for app is found

Fixes #1785

Review-URL: https://codereview.appspot.com/264670043
---------------