Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1502)

Issue 26430044: Sandbox should always use go

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by gary.poster
Modified:
5 years, 10 months ago
Reviewers:
bac, mp+195293
Visibility:
Public.

Description

Sandbox should always use go On jujucharms, bundle deployment wasn't working because we were using the python sandbox (because jujucharms still uses pyjuju). Thank you to Francesco for noticing, diagnosing, and offering a fix. This is his fix with a quick test. https://code.launchpad.net/~gary/charms/precise/juju-gui/legacyJujucharms/+merge/195293 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Sandbox should always use go #

Patch Set 3 : Sandbox should always use go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/utils.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_utils.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
5 years, 10 months ago (2013-11-14 19:18:32 UTC) #1
bac
LGTM, yo.
5 years, 10 months ago (2013-11-14 19:20:28 UTC) #2
gary.poster
*** Submitted: Sandbox should always use go On jujucharms, bundle deployment wasn't working because we ...
5 years, 10 months ago (2013-11-14 20:22:10 UTC) #3
gary.poster
5 years, 10 months ago (2013-11-15 14:45:33 UTC) #4
Thank you, bac!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b