Issue 26430043: goyaml: fix printing of bare hyphens

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26430043: goyaml: fix printing of bare hyphens

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dave

Modified:
11 years ago

Reviewers:
mp+195162, jameinel, wallyworld, rog

Visibility:
Public.

Description

goyaml: fix printing of bare hyphens https://code.launchpad.net/~dave-cheney/goyaml/goyaml/+merge/195162 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	decode_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	emitterc.go	View	1 chunk	+1 line, -1 line	1 comment	Download
M	encode_test.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jameinel

LGTM, is there a bug to associate with this ? (goyaml panics when encountering a ...

11 years ago (2013-11-14 05:36:39 UTC) #3

jameinel

*** Submitted: goyaml: fix printing of bare hyphens related to bug #1227952. Quote a bare ...

11 years ago (2013-11-14 05:43:32 UTC) #4

rog

11 years ago (2013-11-14 09:59:20 UTC) #5

https://codereview.appspot.com/26430043/diff/1/emitterc.go
File emitterc.go (right):

https://codereview.appspot.com/26430043/diff/1/emitterc.go#newcode1015
emitterc.go:1015: if len(value) == 3 && ((value[0] == '-' && value[1] == '-' &&
value[2] == '-') || (value[0] == '.' && value[1] == '.' && value[2] == '.')) {
Are we sure this preserves the same semantics as before?
If the idea is just to avoid the panic, I'd have used ">= 3"
rather than "== 3".

Expand All Messages | Collapse All Messages