Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(253)

Issue 264210043: Add support for ASan to circle CI

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by ekr-rietveld
Modified:
10 years, 7 months ago
Reviewers:
mt
Visibility:
Public.

Description

Add support for ASan to circle CI

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M circle.yml View 1 1 chunk +18 lines, -1 line 2 comments Download

Messages

Total messages: 5
ekr-rietveld
MT, PTAL
10 years, 7 months ago (2015-09-09 19:10:16 UTC) #1
ekr-rietveld
Tested at: https://circleci.com/gh/nss-dev/nss/76
10 years, 7 months ago (2015-09-09 19:13:57 UTC) #2
ekr-rietveld
Cleaned up
10 years, 7 months ago (2015-09-09 20:53:58 UTC) #3
mt
https://codereview.appspot.com/264210043/diff/1/circle.yml File circle.yml (right): https://codereview.appspot.com/264210043/diff/1/circle.yml#newcode15 circle.yml:15: - make ZDEFS_FLAG= CC='clang-3.4 -fsanitize=address -fno-omit-frame-pointer' CCC='clang++-3.4 -fsanitize=address -fno-omit-frame-pointer' ...
10 years, 7 months ago (2015-09-09 21:00:06 UTC) #4
mt
10 years, 7 months ago (2015-09-10 01:34:50 UTC) #5
https://codereview.appspot.com/264210043/diff/20001/circle.yml
File circle.yml (right):

https://codereview.appspot.com/264210043/diff/20001/circle.yml#newcode1
circle.yml:1: checkout:
I didn't notice this before, but I think that you need to move this into
different sections.  The "dependencies" section is where you should install
clang.  The compilation goes in test (maybe as a pre).

https://codereview.appspot.com/264210043/diff/20001/circle.yml#newcode9
circle.yml:9: - cd ..; hg clone https://hg.mozilla.org/projects/nspr
You should tell circle to cache this stuff.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b