code review 26420044: godoc: be quiet about examples

godoc: be quiet by default about bad examples

Fixes issue 6759

[bradfitz, 2013-11-14 03:04:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[adg, 2013-11-14 04:33:26]

https://codereview.appspot.com/26420044/diff/40001/godoc/server.go
File godoc/server.go (right):

https://codereview.appspot.com/26420044/diff/40001/godoc/server.go#newcode335
godoc/server.go:335: } else {
else if c.Verbose

[bradfitz, 2013-11-14 14:39:51]

https://codereview.appspot.com/26420044/diff/40001/godoc/server.go
File godoc/server.go (right):

https://codereview.appspot.com/26420044/diff/40001/godoc/server.go#newcode335
godoc/server.go:335: } else {
On 2013/11/14 04:33:27, adg wrote:
> else if c.Verbose

I couldn't have gotten an LGTM in parallel with this critical fix?

[bradfitz, 2013-11-14 14:40:54]

Hello golang-dev@googlegroups.com, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-11-14 15:10:43]

LGTM

[bradfitz, 2013-11-14 17:01:14]

*** Submitted as
https://code.google.com/p/go/source/detail?r=53091f42b906&repo=tools ***

godoc: be quiet by default about bad examples

Fixes issue 6759

R=golang-dev, adg, rsc
CC=golang-dev
https://codereview.appspot.com/26420044

[adg, 2013-11-14 20:51:32]

Sorry, I just forgot.
On 15 Nov 2013 01:39, <bradfitz@golang.org> wrote:

>
> https://codereview.appspot.com/26420044/diff/40001/godoc/server.go
> File godoc/server.go (right):
>
> https://codereview.appspot.com/26420044/diff/40001/godoc/
> server.go#newcode335
> godoc/server.go:335: } else {
> On 2013/11/14 04:33:27, adg wrote:
>
>> else if c.Verbose
>>
>
> I couldn't have gotten an LGTM in parallel with this critical fix?
>
> https://codereview.appspot.com/26420044/
>