Issue 263730043: Issue 4560: group #include directives at top of file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 263730043: Issue 4560: group #include directives at top of file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by Dan Eble

Modified:
8 years, 8 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Issue 4560: group #include directives at top of file This is so that using-declarations can later be added without appearing before #includes.

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -45 lines)			Patch
M	flower/file-path.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	flower/include/direction.hh	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	flower/std-string.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	lily/collision-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/function-documentation.cc	View	3 chunks	+13 lines, -14 lines	0 comments	Download
M	lily/grid-line-span-engraver.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	lily/grob-pq-engraver.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	lily/ledger-line-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/piano-pedal-align-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/pitched-trill-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/pure-from-neighbor-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/relocate.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lily/rest-collision-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/span-arpeggio-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/span-bar-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/span-bar-stub-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/staff-performer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/system-start-delimiter-engraver.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2

This is a good idea.  LGTM.