Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3611)

Issue 263600043: Adding update/delete interfaces

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by bruce.yinhe.kth
Modified:
8 years, 5 months ago
Visibility:
Public.

Description

Adding update/delete interfaces

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -94 lines) Patch
M src/main/java/se/kth/crypt/server/config/Properties.java View 1 chunk +2 lines, -7 lines 0 comments Download
D src/main/java/se/kth/crypt/server/controller/DeleteController.java View 1 chunk +0 lines, -39 lines 0 comments Download
D src/main/java/se/kth/crypt/server/controller/UpdateController.java View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 5
bruce.yinhe.kth
This commit adds the REST interfaces of "update" and "delete"
8 years, 6 months ago (2015-10-06 14:08:39 UTC) #1
kirill.sc
Removing myself from reviewers, issue can be closed
8 years, 5 months ago (2015-11-21 08:56:40 UTC) #2
teowey
On 2015/11/21 08:56:40, kirill.sc wrote: > Removing myself from reviewers, issue can be closed LGTM
8 years, 5 months ago (2015-11-22 19:55:36 UTC) #3
bruce.yinhe
The "upload.py" script doesn't seem to work? Upload server: codereview.appspot.com (change with -s/--server) New issue ...
8 years, 5 months ago (2015-11-23 00:19:16 UTC) #4
teowey
8 years, 5 months ago (2015-11-23 00:37:37 UTC) #5
I use the option --oauth2 on the command line to bypass this error:

*./upload.py <old commit ID > <new commit ID> --oauth2*



Teo

On Sun, Nov 22, 2015 at 4:18 PM, Bruce Yinhe <bruce.yinhe@gmail.com> wrote:

> The "upload.py" script doesn't seem to work?
>
>
>
> Upload server: codereview.appspot.com (change with -s/--server)
> New issue subject: Added MasterElectionCalculator. We can now calculate
> the points at any time
> Email (login for uploading to codereview.appspot.com) [
> bruce.yinhe.kth@gmail.com]:
> Password for bruce.yinhe.kth@gmail.com:
> Traceback (most recent call last):
>   File "./upload.py", line 2719, in <module>
>     main()
>   File "./upload.py", line 2711, in main
>     RealMain(sys.argv)
>   File "./upload.py", line 2667, in RealMain
>     response_body = rpc_server.Send("/upload", body, content_type=ctype)
>   File "./upload.py", line 446, in Send
>     self._Authenticate()
>   File "./upload.py", line 501, in _Authenticate
>     super(HttpRpcServer, self)._Authenticate()
>   File "./upload.py", line 381, in _Authenticate
>     auth_token = self._GetAuthToken(credentials[0], credentials[1])
>   File "./upload.py", line 325, in _GetAuthToken
>     response = self.opener.open(req)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
> line 437, in open
>     response = meth(req, response)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
> line 550, in http_response
>     'http', request, response, code, msg, hdrs)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
> line 475, in error
>     return self._call_chain(*args)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
> line 409, in _call_chain
>     result = func(*args)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py",
> line 558, in http_error_default
>     raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
> urllib2.HTTPError: HTTP Error 404: Not Found
>
>
> Bruce
>
> On Sun, Nov 22, 2015 at 8:55 PM, <teowey@gmail.com> wrote:
>
>> On 2015/11/21 08:56:40, kirill.sc wrote:
>>
>>> Removing myself from reviewers, issue can be closed
>>>
>>
>> LGTM
>>
>> https://codereview.appspot.com/263600043/
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b