Issue 262490044: TBR: i#573,i#1636 annotations: add leak check annotation handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 262490044: TBR: i#573,i#1636 annotations: add leak check annotation handling

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by bruening

Modified:
10 years, 9 months ago

Reviewers:
zhaoqin

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#573,i#1636 annotations: add leak check annotation handling Adds a handler for the VALGRIND_DO_LEAK_CHECK annotation, for use in our tests. Requires DR 4050f4f. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -6 lines)			Patch
M	drheapstat/drheapstat.c	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	drmemory/alloc_drmem.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	drmemory/annotations.c	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	drmemory/docs/release.dox	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/valgrind/memcheck.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

10 years, 9 months ago (2015-09-23 04:37:18 UTC) #2

Committed as
https://github.com/DynamoRIO/drmemory/commit/d576b294b0b26ccd6be7f71f3282fb02...

Final commit log: 
---------------
i#573,i#1636 annotations: add leak check annotation handling

Adds a handler for the VALGRIND_DO_LEAK_CHECK annotation, for use in our
tests.  Requires DR 4050f4f.

Review-URL: https://codereview.appspot.com/262490044
---------------

Expand All Messages | Collapse All Messages