Issue 26240044: code review 26240044: runtime: write only to NaCl stdout, never to NaCl stderr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26240044: code review 26240044: runtime: write only to NaCl stdout, never to NaCl stderr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
adg

CC:
adg

Visibility:
Public.

Description

runtime: write only to NaCl stdout, never to NaCl stderr NaCl writes some other messages on standard error that we would like to be able to squelch.

Patch Set 1 #

Patch Set 2 : diff -r 24f64e1eaa8a https://code.google.com/r/rsc-go13nacl #

Patch Set 3 : diff -r 24f64e1eaa8a https://code.google.com/r/rsc-go13nacl #

Patch Set 4 : diff -r 24f64e1eaa8a https://code.google.com/r/rsc-go13nacl #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/runtime/sys_nacl_amd64p32.s	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg, I'd like you to review this change to https://code.google.com/r/rsc-go13nacl

10 years, 5 months ago (2013-11-13 21:52:32 UTC) #1

rsc

10 years, 5 months ago (2013-11-13 22:03:56 UTC) #3

*** Submitted as d1f615bbb6e4 ***

runtime: write only to NaCl stdout, never to NaCl stderr

NaCl writes some other messages on standard error
that we would like to be able to squelch.

R=adg
https://codereview.appspot.com/26240044

Expand All Messages | Collapse All Messages