Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(459)

Issue 26190043: Fix base Python dependencies.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by frankban
Modified:
7 years, 3 months ago
Reviewers:
mp+195113, gary.poster
Visibility:
Public.

Description

Fix base Python dependencies. The install hook imported charmhelpers before installing python-yaml, and charmhelpers imports from yaml. This very old bug has been hidden by the fact that python-yaml is automatically installed in ec2/lxc instances, but showed itself when using the manual provider. Copy/pasting and integrating the QA from my last branch, a double check can help before the release. QA: - Bootstrap a Juju environment with --debug. - Deploy and expose the GUI (make deploy). - Check juju debug-log (or less ~/.juju/local/log/unit-juju-gui-0.log if you used lxc): you should see the following message at the beginning of the install hook log: "Installing base Python dependencies: python-apt, python-launchpadlib, python-tempita, python-yaml." - Wait for the GUI to be ready/started. - Deploy this bundle: http://pastebin.ubuntu.com/6411548/ - Check everything is ok, xy annotations work ( the services are vertically aligned), wordpress has customized constraints, mysql customized options and two units. - No try to deploy the same bundle again, you will see a "services already there" kind of error. https://code.launchpad.net/~frankban/charms/precise/juju-gui/install-yaml/+merge/195113 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix base Python dependencies. #

Patch Set 3 : Fix base Python dependencies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/backend.py View 1 chunk +1 line, -2 lines 0 comments Download
M hooks/install View 1 2 chunks +10 lines, -6 lines 0 comments Download
M hooks/utils.py View 3 chunks +12 lines, -12 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M server-requirements.pip View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/test_backends.py View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
7 years, 3 months ago (2013-11-13 18:35:27 UTC) #1
frankban
Please take a look.
7 years, 3 months ago (2013-11-13 18:37:50 UTC) #2
gary.poster
LGTM and QAOK. Thank you!
7 years, 3 months ago (2013-11-13 18:57:27 UTC) #3
frankban
7 years, 3 months ago (2013-11-13 19:03:37 UTC) #4
*** Submitted:

Fix base Python dependencies.

The install hook imported charmhelpers
before installing python-yaml, and 
charmhelpers imports from yaml.

This very old bug has been hidden by the 
fact that python-yaml is automatically 
installed in ec2/lxc instances, but showed
itself when using the manual provider.

Copy/pasting and integrating the QA from 
my last branch, a double check can help
before the release.
QA:
- Bootstrap a Juju environment with --debug.
- Deploy and expose the GUI (make deploy).
- Check juju debug-log (or
  less ~/.juju/local/log/unit-juju-gui-0.log if you
  used lxc): you should see the following message
  at the beginning of the install hook log:
  "Installing base Python dependencies: python-apt, 
  python-launchpadlib, python-tempita, python-yaml."
- Wait for the GUI to be ready/started.
- Deploy this bundle: http://pastebin.ubuntu.com/6411548/
- Check everything is ok, xy annotations work (
  the services are vertically aligned), wordpress has
  customized constraints, mysql customized options and
  two units.
- No try to deploy the same bundle again, you
  will see a "services already there" kind of error.

R=gary.poster
CC=
https://codereview.appspot.com/26190043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b