Issue 261680043: miscellaneous restructoring and stuff based on code review issue: https://codereview.appspot.com/26…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 261680043: miscellaneous restructoring and stuff based on code review issue: https://codereview.appspot.com/26…

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by robert.erneborg

Modified:
8 years, 5 months ago

Reviewers:
marcus.falgert, fikri.firman, dkostic, teowey, karthik.venkatesan85, bruce.yinhe.kth, bruce.yinhe

Visibility:
Public.

More Reviews

Description

miscellaneous restructoring and stuff based on code review issue: https://codereview.appspot.com/26… Changed a lot of miscellaneous restructoring and stuff based on the code review. I also merged the controller classes to one big one since there were no point in having 5 of them (not tested, will be tested Oct. 08). I also added a configuration for the scheduled tasks which otherwise threw exception (tested and works).

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -277 lines)			Patch
M	crypt-server.iml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/main/java/se/kth/crypt/server/config/AppInitializer.java	View	3 chunks	+6 lines, -5 lines	0 comments	Download
A	src/main/java/se/kth/crypt/server/config/SchedulingConfig.java	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	src/main/java/se/kth/crypt/server/controller/DatabaseController.java	View	1 chunk	+121 lines, -0 lines	0 comments	Download
D	src/main/java/se/kth/crypt/server/controller/DeleteController.java	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	src/main/java/se/kth/crypt/server/controller/IndexController.java	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	src/main/java/se/kth/crypt/server/controller/ReadController.java	View	1 chunk	+0 lines, -53 lines	0 comments	Download
D	src/main/java/se/kth/crypt/server/controller/UpdateController.java	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	src/main/java/se/kth/crypt/server/controller/WriteController.java	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	src/main/java/se/kth/crypt/server/core/DatabaseUpdateReceiver.java	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/main/java/se/kth/crypt/server/core/MasterElectionReceiver.java	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/main/java/se/kth/crypt/server/core/ScheduledTasks.java	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/main/resources/log4j.properties	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	target/MANIFEST.MF	View	1 chunk	+1 line, -1 line	0 comments	Download
M	target/classes/log4j.properties	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	target/crypt-server/META-INF/MANIFEST.MF	View	1 chunk	+1 line, -1 line	0 comments	Download
M	target/crypt-server/WEB-INF/classes/log4j.properties	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Removing myself from reviewers, issue can be closed

Expand All Messages | Collapse All Messages