Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 26130043: Update requirements and improve their handling.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by frankban
Modified:
7 years, 3 months ago
Reviewers:
mp+195100, gary.poster
Visibility:
Public.

Description

Update requirements and improve their handling. Updated the juju-deployer and jujucleint dependencies to the latest versions, which include our recent fixes. This way we avoid using our own forks of the projects. Updated the code that installs the builtin server dependencies: now a pip requirement file is used, and the test requirement file includes the former. The overall dependency infrastructure should now be less confusing. Also added documentation about how to update the builtin server requirements. Removed the no longer required --upload-tools from the functional tests runner. The deployer functional tests now also use bundles including numunits > 1 and constraints. QA: - Bootstrap a Juju environment. - Deploy and expose the GUI (make deploy). - Wait for the GUI to be ready/started. - Deploy this bundle: http://pastebin.ubuntu.com/6411548/ - Check everything is ok, xy annotations work ( the services are vertically aligned), wordpress has customized constraints, mysql customized options and two units. - No try to deploy the same bundle again, you will see a "services already there" kind of error. https://code.launchpad.net/~frankban/charms/precise/juju-gui/new-requirements/+merge/195100 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update requirements and improve their handling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -30 lines) Patch
M HACKING.md View 1 chunk +10 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +4 lines, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D deps/juju-deployer-0.2.8.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/juju-deployer-0.2.9.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
D deps/jujuclient-0.13.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/jujuclient-0.15.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
M hooks/utils.py View 2 chunks +9 lines, -17 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
A server-requirements.pip View 1 1 chunk +26 lines, -0 lines 0 comments Download
M test-requirements.pip View 2 chunks +3 lines, -7 lines 0 comments Download
M tests/00-setup View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/example.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/test_utils.py View 3 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
7 years, 3 months ago (2013-11-13 17:02:10 UTC) #1
gary.poster
LGTM with trivial comment request. Doing QA now. https://codereview.appspot.com/26130043/diff/1/hooks/utils.py File hooks/utils.py (right): https://codereview.appspot.com/26130043/diff/1/hooks/utils.py#newcode550 hooks/utils.py:550: '--find-links', ...
7 years, 3 months ago (2013-11-13 17:15:47 UTC) #2
gary.poster
QA good. Thanks!
7 years, 3 months ago (2013-11-13 17:26:55 UTC) #3
frankban
7 years, 3 months ago (2013-11-13 17:50:10 UTC) #4
*** Submitted:

Update requirements and improve their handling.

Updated the juju-deployer and jujucleint
dependencies to the latest versions, which
include our recent fixes. This way we avoid
using our own forks of the projects.

Updated the code that installs the builtin
server dependencies: now a pip requirement
file is used, and the test requirement file
includes the former. The overall dependency
infrastructure should now be less confusing.

Also added documentation about how to update
the builtin server requirements.

Removed the no longer required --upload-tools
from the functional tests runner.

The deployer functional tests now also use
bundles including numunits > 1 and constraints.

QA:
- Bootstrap a Juju environment.
- Deploy and expose the GUI (make deploy).
- Wait for the GUI to be ready/started.
- Deploy this bundle: http://pastebin.ubuntu.com/6411548/
- Check everything is ok, xy annotations work (
  the services are vertically aligned), wordpress has
  customized constraints, mysql customized options and
  two units.
- No try to deploy the same bundle again, you
  will see a "services already there" kind of error.

R=gary.poster
CC=
https://codereview.appspot.com/26130043

https://codereview.appspot.com/26130043/diff/1/server-requirements.pip
File server-requirements.pip (right):

https://codereview.appspot.com/26130043/diff/1/server-requirements.pip#newcode19
server-requirements.pip:19: # Note: the order of the following dependencies is
important!
On 2013/11/13 17:15:47, gary.poster wrote:
> Would be nice to indicate why.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b