Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1300)

Issue 260810043: Issue 4564: make Grob an abstract class (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by Dan Eble
Modified:
8 years, 6 months ago
Reviewers:
pkx166h, dak, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

... in preparation for deriving grob interface classes (e.g. Accidental_interface) from Grob without risking unintentional instantiation anywhere.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M lily/grob.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/include/grob.hh View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10
Dan Eble
8 years, 7 months ago (2015-08-16 13:42:07 UTC) #1
pkx166h
Patch counted down please push. PATCH_PUSH
8 years, 7 months ago (2015-08-26 07:07:12 UTC) #2
hanwenn
not LGTM I'll follow up on the bug. On 2015/08/26 07:07:12, J_lowe wrote: > Patch ...
8 years, 7 months ago (2015-08-26 11:17:23 UTC) #3
dak
On 2015/08/26 11:17:23, hanwenn wrote: > not LGTM > > I'll follow up on the ...
8 years, 7 months ago (2015-08-26 11:22:18 UTC) #4
hanwenn
On 2015/08/26 11:22:18, dak wrote: > On 2015/08/26 11:17:23, hanwenn wrote: > > not LGTM ...
8 years, 7 months ago (2015-08-26 11:26:56 UTC) #5
Dan Eble
On 2015/08/26 11:26:56, hanwenn wrote: > "preparation of .. " : deriving from Grob is ...
8 years, 7 months ago (2015-08-26 21:18:49 UTC) #6
hanwenn
On 2015/08/26 21:18:49, Dan Eble wrote: > On 2015/08/26 11:26:56, hanwenn wrote: > > > ...
8 years, 7 months ago (2015-08-28 15:17:10 UTC) #7
hanwenn
On 2015/08/28 15:17:10, hanwenn wrote: > On 2015/08/26 21:18:49, Dan Eble wrote: > > On ...
8 years, 7 months ago (2015-08-28 15:18:47 UTC) #8
Dan Eble
On 2015/08/28 15:18:47, hanwenn wrote: > > Yes, please chnage the commit message. Also, you ...
8 years, 7 months ago (2015-08-28 21:01:22 UTC) #9
pkx166h
8 years, 7 months ago (2015-08-29 07:47:43 UTC) #10
Leaving on 'review' for now.

PATCH_REVIEW
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b