Issue 260720043: Issue 4540: Rename Grob::pure_height() to pure_y_extent()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 260720043: Issue 4540: Rename Grob::pure_height() to pure_y_extent() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by Dan Eble

Modified:
8 years, 8 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Rename Grob::pure_height() to pure_y_extent() to avoid ambiguity with pure_height() callbacks in many grob-interface classes. This is preparatory to deriving the interface classes from Grob.

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	lily/accidental-placement.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/align-interface.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/axis-group-interface.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/flag.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/grob.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/grob-scheme.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/include/grob.hh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/include/item.hh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/item.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/note-spacing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/separation-item.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/slur.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lily/staff-spacing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/stem-tremolo.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lily/system.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages