Issue 260070043: Bug fixes:

Issue 260070043: Bug fixes: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by scudette

Modified:
8 years, 8 months ago

Reviewers:
Jordi, amoser

CC:
rekall-dev_googlegroups.com

Base URL:
https://github.com/google/rekall.git@master

Visibility:
Public.

More Reviews

Description

Bug fixes: - File mappings have to be page aligned - Catch failure to resolve name of pagefile which is itself paged. - Catch failures in mimikatz to find rpce records. - Small tweaks for build system. BUG= R=amoser@google.com Committed: 2d693d7

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -36 lines)			Patch
M	.gitignore	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	rekall-core/rekall/plugins/addrspaces/aff4.py	View		3 chunks	+25 lines, -6 lines	0 comments	Download
M	rekall-core/rekall/plugins/addrspaces/win32.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	rekall-core/rekall/plugins/common/sigscan.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	rekall-core/rekall/plugins/windows/heap_analysis.py	View		6 chunks	+27 lines, -12 lines	0 comments	Download
M	rekall-core/rekall/plugins/windows/mimikatz.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	rekall-core/rekall/plugins/windows/pagefile.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	rekall-core/rekall/rekal.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	rekall-core/rekall/scan.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	rekall-gui/setup.py	View		4 chunks	+7 lines, -2 lines	0 comments	Download
M	tools/installers/rekall.iss	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/installers/rekall_x86.iss	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/installers/winbuild.bat	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	tools/installers/winbuild_x86.bat	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

amoser

LGTM https://codereview.appspot.com/260070043/diff/1/tools/installers/winbuild.bat File tools/installers/winbuild.bat (right): https://codereview.appspot.com/260070043/diff/1/tools/installers/winbuild.bat#newcode8 tools/installers/winbuild.bat:8: signtool sign /n Michael /t http://timestamp.verisign.com/scripts/timestamp.dll dist\rekal\*.exe Let's ...

8 years, 8 months ago (2015-08-10 15:41:21 UTC) #2

scudette

Committed patchset #2 manually as r2d693d7 (presubmit successful).

8 years, 8 months ago (2015-08-10 15:51:30 UTC) #3

scudette

8 years, 8 months ago (2015-08-10 15:51:34 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/260070043/diff/1/tools/installers/winbuild.bat
File tools/installers/winbuild.bat (right):

https://codereview.appspot.com/260070043/diff/1/tools/installers/winbuild.bat...
tools/installers/winbuild.bat:8: signtool sign /n Michael /t
http://timestamp.verisign.com/scripts/timestamp.dll dist\rekal\*.exe
On 2015/08/10 15:41:21, amoser wrote:
> Let's not hardcode the subject name.

Done.

https://codereview.appspot.com/260070043/diff/1/tools/installers/winbuild_x86...
File tools/installers/winbuild_x86.bat (right):

https://codereview.appspot.com/260070043/diff/1/tools/installers/winbuild_x86...
tools/installers/winbuild_x86.bat:8: signtool sign  /v /n Michael /t
http://timestamp.verisign.com/scripts/timestamp.dll dist\rekal\*.exe
On 2015/08/10 15:41:21, amoser wrote:
> same.

Done.

Expand All Messages | Collapse All Messages