Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(22)

Issue 25900043: typo: Fix a typo in a warning

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by jameinel
Modified:
10 years, 6 months ago
Reviewers:
mp+194993, axw
Visibility:
Public.

Description

typo: Fix a typo in a warning We accidentally had "% should" rather than something like "%s should". I went with "%q should" because that matched how we wrote the other variable eariler in the message. I still don't understand why the log message: http://162.213.34.53:8080/job/upgrade-and-deploy-devel/29/console is chock full of Warnings about environments that we shouldn't be using. I can understand seeing a warning about the active environment, but I thought we didn't try to Validate environments that we weren't using. Anyway, *this* fix should be trivially obvious. https://code.launchpad.net/~jameinel/juju-core/typo-1250149/+merge/194993 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/config/config.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
jameinel
Please take a look.
10 years, 6 months ago (2013-11-13 07:12:18 UTC) #1
axw
On 2013/11/13 07:12:18, jameinel wrote: > Please take a look. LGTM We don't validate the ...
10 years, 6 months ago (2013-11-13 07:17:12 UTC) #2
axw
10 years, 6 months ago (2013-11-13 07:18:44 UTC) #3
On 2013/11/13 07:17:12, axw wrote:
> On 2013/11/13 07:12:18, jameinel wrote:
> > Please take a look.
> 
> LGTM
> 
> We don't validate the config in the sense of using the provider's Validate
> method, but reading environments.yaml does do a config.New for each section.
> That's where the deprecation warning lies.

So, re-reading, I guess you actually knew that :)
Perhaps we should just store the bytes, and defer the config.New until it's
requested.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b