Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 258980043: Upgrade Jetty and make test server listen only on localhost. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by kpreid_google
Modified:
8 years, 9 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

Fixes half of <https://github.com/google/caja/issues/1964>, test server being visible to the network. The Jetty upgrade is needed because the ancient Jetty version we had did not allow binding to an address. We are upgrading to Jetty 8, not Jetty 9, so as to not require Java 8. @ 4391844cd376865e0c58499b2815fd3e8dab6ef5 and faa0152cc1881cad3b9f18dc067e65ff82554f97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3801 lines, -1641 lines) Patch
M build.xml View 4 chunks +16 lines, -8 lines 0 comments Download
M src/com/google/caja/service/CajolingServiceMain.java View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/com/google/caja/plugin/BrowserTestCase.java View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/com/google/caja/plugin/ModulesBrowserTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/service/TestHttpServletRequest.java View 6 chunks +52 lines, -3 lines 0 comments Download
M tests/com/google/caja/service/TestHttpServletResponse.java View 3 chunks +11 lines, -0 lines 0 comments Download
M tests/com/google/caja/util/LocalServer.java View 4 chunks +21 lines, -16 lines 0 comments Download
D tests/com/google/caja/util/WrapperResource.java View 1 chunk +0 lines, -103 lines 0 comments Download
A + third_party/java/jetty/LICENSE-APACHE-2.0.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/LICENSE-ECLIPSE-1.0.html View 1 chunk +320 lines, -0 lines 0 comments Download
D third_party/java/jetty/LICENSES/LICENSE.txt View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/java/jetty/LICENSES/NOTICE.txt View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/java/jetty/README.txt View 1 chunk +37 lines, -108 lines 0 comments Download
M third_party/java/jetty/VERSION.txt View 190 chunks +3205 lines, -638 lines 0 comments Download
A third_party/java/jetty/about.html View 1 chunk +20 lines, -0 lines 0 comments Download
D third_party/java/jetty/lib/jetty.jar View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/java/jetty/lib/jetty-6.1.15.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/jetty-continuation.jar View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/java/jetty/lib/jetty-continuation-8.1.17.v20150415.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/jetty-http.jar View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/java/jetty/lib/jetty-http-8.1.17.v20150415.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/jetty-io.jar View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/java/jetty/lib/jetty-io-8.1.17.v20150415.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/jetty-security.jar View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/java/jetty/lib/jetty-security-8.1.17.v20150415.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/jetty-server.jar View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/java/jetty/lib/jetty-server-8.1.17.v20150415.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/jetty-servlet.jar View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/java/jetty/lib/jetty-servlet-8.1.17.v20150415.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/java/jetty/lib/jetty-util.jar View 1 chunk +1 line, -1 line 0 comments Download
D third_party/java/jetty/lib/jetty-util-6.1.15.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/jetty-util-8.1.17.v20150415.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/lib/servlet-api-3.0.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/java/jetty/notice.html View 1 chunk +111 lines, -0 lines 0 comments Download
D third_party/java/jsdk2.1/LICENSE View 1 chunk +0 lines, -184 lines 0 comments Download
D third_party/java/jsdk2.1/README View 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/java/jsdk2.1/default.cfg View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/java/jsdk2.1/etc/SimpleStartup.java View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/java/jsdk2.1/servlet.jar View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/java/jsdk2.1/startserver View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/java/jsdk2.1/startserver.bat View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/java/jsdk2.1/stopserver View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/java/jsdk2.1/stopserver.bat View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 2
kpreid_google
8 years, 9 months ago (2015-07-27 23:39:00 UTC) #1
felix8a
8 years, 9 months ago (2015-07-27 23:54:26 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b