Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4661)

Issue 258160043: Fix LilyPond default fonts definition

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by trueroad
Modified:
8 years, 8 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4544 / 3: Fix makefiles for LilyPond local fontconfig conf file dividing This commit fixes LilyPond local fontconfig conf file dividing. Issue 4544 / 2: Fix LilyPond default fonts definition Due to conf file loading order, generic font aliases `serif', `sans-serif', 'monospace' were unavailable in LilyPond default fonts definition. So the glyphs that are not contained in the list of font definition, like Japanese glyphs were used unexpected font. This commit changes LilyPond default fonts definition loading order for enabling the aliases. Issue 4544 / 1: Divide LilyPond local fontconfig conf file loading This commit divides LilyPond local fontconfig conf file loading into each before and after loading default conf file.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix typo and message #

Patch Set 3 : Fix git diff option #

Patch Set 4 : Fix makefile ln error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -31 lines) Patch
M GNUmakefile.in View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M lily/font-config.cc View 1 2 chunks +35 lines, -12 lines 0 comments Download
A + mf/00-lilypond-fonts.conf.in View 1 chunk +0 lines, -14 lines 0 comments Download
A mf/99-lilypond-fonts.conf.in View 1 chunk +19 lines, -0 lines 0 comments Download
M mf/GNUmakefile View 1 chunk +2 lines, -1 line 0 comments Download
M scm/font.scm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
lemzwerg
LGTM https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode43 lily/font-config.cc:43: /* Create an empty configureation */ s/configureation/configuration/ https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode70 ...
8 years, 9 months ago (2015-08-08 14:08:45 UTC) #1
trueroad
Fix typo and message
8 years, 9 months ago (2015-08-08 16:46:36 UTC) #2
trueroad
https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode43 lily/font-config.cc:43: /* Create an empty configureation */ On 2015/08/08 14:08:45, ...
8 years, 9 months ago (2015-08-08 17:02:16 UTC) #3
trueroad
Fix git diff option
8 years, 8 months ago (2015-08-09 13:18:59 UTC) #4
trueroad
Fix makefile ln error
8 years, 8 months ago (2015-08-10 05:54:09 UTC) #5
trueroad
8 years, 8 months ago (2015-08-14 10:56:45 UTC) #6
I've pushed to staging.

Issue 4544 / 1: Divide LilyPond local fontconfig conf file loading
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Sat, 8 Aug 2015 13:16:41 +0000 (22:16 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 14 Aug 2015 10:47:42 +0000 (19:47 +0900)
commit    62a6e9aef6f164641a4ac57e3342b7917c6a53b0


Issue 4544 / 2: Fix LilyPond default fonts definition
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Sat, 8 Aug 2015 10:06:50 +0000 (19:06 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 14 Aug 2015 10:47:42 +0000 (19:47 +0900)
commit    0fbbdc6c58432060770d3d4f76e063c2028c0023


Issue 4544 / 3: Fix makefiles for LilyPond local fontconfig conf file dividing
staging
author    Masamichi Hosoda <trueroad@trueroad.jp>
          Sat, 8 Aug 2015 12:15:37 +0000 (21:15 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
          Fri, 14 Aug 2015 10:47:43 +0000 (19:47 +0900)
commite   bd5a4af248c95178abb8490a32c0b8d3af4e1d7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b