Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 258130043: TBR: i#1732 drcpusim: add cpuid fooling

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by bruening
Modified:
10 years, 10 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1732 drcpusim: add cpuid fooling Adds cpuid fooling for all of the Intel models supported by drcpusim, under an on-by-default option -fool_cpuid. Only the feature queries (along with max values and brands reporting alongside) are fooled: all other cpuid queries are unchanged. The cpuid information for each model is stored in a struct in the code. Adds tests to the suite for cpuid fooling for Klamath through Ivybridge. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+777 lines, -122 lines) Patch
M clients/drcpusim/drcpusim.cpp View 19 chunks +430 lines, -120 lines 0 comments Download
M clients/drcpusim/options.h View 1 chunk +1 line, -0 lines 0 comments Download
M clients/drcpusim/options.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid.c View 1 chunk +166 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Banias.expect View 1 chunk +12 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Deschutes.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Ivybridge.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Klamath.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Merom.expect View 1 chunk +14 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Penryn.expect View 1 chunk +15 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Pentium3.expect View 1 chunk +11 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Prescott.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Presler.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Sandybridge.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A clients/drcpusim/tests/cpuid-Westmere.expect View 1 chunk +16 lines, -0 lines 0 comments Download
M suite/tests/CMakeLists.txt View 1 chunk +27 lines, -2 lines 0 comments Download

Messages

Total messages: 2
bruening
10 years, 10 months ago (2015-08-06 00:41:04 UTC) #1
bruening
10 years, 10 months ago (2015-08-06 00:41:07 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/86ed8853f158828b9588dbdbf9b3ca7...

Final commit log: 
---------------
i#1732 drcpusim: add cpuid fooling

Adds cpuid fooling for all of the Intel models supported by drcpusim, under
an on-by-default option -fool_cpuid.  Only the feature queries (along with
max values and brands reporting alongside) are fooled: all other cpuid
queries are unchanged.  The cpuid information for each model is stored in a
struct in the code.

Adds tests to the suite for cpuid fooling for Klamath through Ivybridge.

Review-URL: https://codereview.appspot.com/258130043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b