Issue 258040043: Initial local map_traces implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 258040043: Initial local map_traces implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by nduca

Modified:
8 years, 9 months ago

Reviewers:

CC:
tracing-review_chromium.org

Base URL:
https://github.com/google/trace-viewer.git@webapp2_devserver

Visibility:
Public.

More Reviews

Description

Initial local map_traces implementation BUG=#1063 Committed: https://chromium.googlesource.com/external/trace-viewer/+/a4cd23d6d3acc76da3a53cbc2974713b49df388d

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : ready #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+605 lines, -36 lines)			Patch
D	perf_insights/__init__.py	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	perf_insights/bin/__init__.py	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
D	perf_insights/bin/map_traces	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	perf_insights/bin/map_traces.py	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
A +	perf_insights/bin/map_traces_locally	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
A	perf_insights/bin/map_traces_locally.py	View	1 2 3 4	1 chunk	+78 lines, -0 lines	0 comments	Download
A	perf_insights/examples/map_load_time.html	View	1 2 3	1 chunk	+13 lines, -0 lines	0 comments	Download
M	perf_insights/perf_insights/__init__.py	View	1	1 chunk	+21 lines, -1 line	0 comments	Download
A +	perf_insights/perf_insights/corpus_driver.py	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
A	perf_insights/perf_insights/get_trace_handles_query.py	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	perf_insights/perf_insights/json_map_results.py	View	1 2 3 4	1 chunk	+50 lines, -0 lines	0 comments	Download
A	perf_insights/perf_insights/local_directory_corpus_driver.py	View	1 2 3	1 chunk	+68 lines, -0 lines	0 comments	Download
A +	perf_insights/perf_insights/local_directory_corpus_driver_unittest.py	View	1 4	1 chunk	+4 lines, -2 lines	0 comments	Download
A	perf_insights/perf_insights/local_file_trace_handle.py	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	perf_insights/perf_insights/map_results.py	View	1 2 3 4	1 chunk	+25 lines, -0 lines	0 comments	Download
A	perf_insights/perf_insights/map_single_trace.html	View	1 2 3	1 chunk	+126 lines, -0 lines	0 comments	Download
A	perf_insights/perf_insights/map_single_trace.py	View	1 2 3 4	1 chunk	+86 lines, -0 lines	0 comments	Download
A	perf_insights/perf_insights/map_single_trace_cmdline.html	View	1 2 3	1 chunk	+26 lines, -0 lines	0 comments	Download
A +	perf_insights/perf_insights/map_traces_handler.py	View	1 4	1 chunk	+7 lines, -2 lines	0 comments	Download
A	perf_insights/perf_insights/trace_handle.py	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
A	perf_insights/perf_insights/trace_run_info.py	View	1 2 3	1 chunk	+30 lines, -0 lines	0 comments	Download
A +	perf_insights/run_pi_dev_server	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tracing/tracing/base/xhr.html	View	1 2 3 4	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

nduca

8 years, 9 months ago (2015-08-01 00:24:41 UTC) #1

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
a4cd23d6d3acc76da3a53cbc2974713b49df388d (presubmit successful).

Expand All Messages | Collapse All Messages