Add comment to font.scm and lilypond-fonts.conf.in

Add comment to font.scm and lilypond-fonts.conf.in

From comments in:

http://lists.gnu.org/archive/html/
lilypond-devel/2015-06/msg00175.html

Added appropriate comments
in scm/font.scm and
mf/lilypond-fonts.conf.in

[trueroad, 2015-07-27 12:10:24]

https://codereview.appspot.com/257940043/diff/1/scm/font.scm
File scm/font.scm (right):

https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254
scm/font.scm:254: ; are aliases that are defined in mf/lilypond-fonts.conf.in.
`mf/lilypond-fonts.conf.in' is filename in the source files.
It is changed by makefiles at building lilypond binaries and installers.
Its installed filename is `font/lilypond-fonts.conf'.

[pkx166h, 2015-07-27 12:27:26]

On 2015/07/27 12:10:24, trueroad wrote:
> https://codereview.appspot.com/257940043/diff/1/scm/font.scm
> File scm/font.scm (right):
> 
> https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254
> scm/font.scm:254: ; are aliases that are defined in mf/lilypond-fonts.conf.in.
> `mf/lilypond-fonts.conf.in' is filename in the source files.
> It is changed by makefiles at building lilypond binaries and installers.
> Its installed filename is `font/lilypond-fonts.conf'.

Maybe I am missing something - I am not a programmer - we cannot add comments in
files that don't exist in the source but that are generated when they are 'made'
(or built or whatever term you use). So as the file font/lilypond-fonts.conf
doesn't actually exist, I don't know how else we would be able to tell the user
what these 'LilyPond' fonts mean. Or did I misunderstand what you are telling me
here? Sorry if that is the case.

[trueroad, 2015-07-27 14:23:52]

On 2015/07/27 12:27:26, J_lowe wrote:
> On 2015/07/27 12:10:24, trueroad wrote:
> > https://codereview.appspot.com/257940043/diff/1/scm/font.scm
> > File scm/font.scm (right):
> > 
> > https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254
> > scm/font.scm:254: ; are aliases that are defined in
mf/lilypond-fonts.conf.in.
> > `mf/lilypond-fonts.conf.in' is filename in the source files.
> > It is changed by makefiles at building lilypond binaries and installers.
> > Its installed filename is `font/lilypond-fonts.conf'.
> 
> Maybe I am missing something - I am not a programmer - we cannot add comments
in
> files that don't exist in the source but that are generated when they are
'made'
> (or built or whatever term you use). So as the file font/lilypond-fonts.conf
> doesn't actually exist, I don't know how else we would be able to tell the
user
> what these 'LilyPond' fonts mean. Or did I misunderstand what you are telling
me
> here? Sorry if that is the case.

In current lilypond, source file `mf/lilyond-fonts.conf.in' and installed file
`font/lilypond-fonts.conf' are same.
So your patch for `mf/lilypond-fonts.conf.in' is also effective for
`font/lilypond-fonts.conf'.

On the other hand, the comment in your patch for `scm/fonts.scm' describes
`mf/lilypond-fonts.conf.in' only.
It doesn't describe `font/lilypond-fonts.conf'.

When you read the comment in `scm/fonts.scm' in the source files, you can find
`mf/lilypond-fonts.conf.in' in the source files.
However, when you read the comment in `scm/fonts.scm' in the installed files,
you can not find `mf/lilypond-fonts.conf.in' in the installed files.
`mf/lilypond-fonts.conf.in' isn't contained in the installed files.
`font/lilypond-fonts.conf' is contained in the installed files.

How about this?
```
; Note that 'LilyPond Serif', 'LilyPond Sans Serif' and 'Lilypond Monospace'
; are aliases that are defined in mf/lilypond-fonts.conf.in (source file)

; or fonts/lilypond-fonts.conf (installed file).
```

[pkx166h, 2015-07-28 16:05:36]

With Hosada-San's comments

[pkx166h, 2015-07-28 16:05:52]

On 2015/07/27 14:23:52, trueroad wrote:
> On 2015/07/27 12:27:26, J_lowe wrote:
> > On 2015/07/27 12:10:24, trueroad wrote:
> > > https://codereview.appspot.com/257940043/diff/1/scm/font.scm
> > > File scm/font.scm (right):
> > > 
> > > https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254
> > > scm/font.scm:254: ; are aliases that are defined in
> mf/lilypond-fonts.conf.in.
> > > `mf/lilypond-fonts.conf.in' is filename in the source files.
> > > It is changed by makefiles at building lilypond binaries and installers.
> > > Its installed filename is `font/lilypond-fonts.conf'.
> > 
> > Maybe I am missing something - I am not a programmer - we cannot add
comments
> in
> > files that don't exist in the source but that are generated when they are
> 'made'
> > (or built or whatever term you use). So as the file font/lilypond-fonts.conf
> > doesn't actually exist, I don't know how else we would be able to tell the
> user
> > what these 'LilyPond' fonts mean. Or did I misunderstand what you are
telling
> me
> > here? Sorry if that is the case.
> 
> In current lilypond, source file `mf/lilyond-fonts.conf.in' and installed file
> `font/lilypond-fonts.conf' are same.
> So your patch for `mf/lilypond-fonts.conf.in' is also effective for
> `font/lilypond-fonts.conf'.
> 
> On the other hand, the comment in your patch for `scm/fonts.scm' describes
> `mf/lilypond-fonts.conf.in' only.
> It doesn't describe `font/lilypond-fonts.conf'.
> 
> When you read the comment in `scm/fonts.scm' in the source files, you can find
> `mf/lilypond-fonts.conf.in' in the source files.
> However, when you read the comment in `scm/fonts.scm' in the installed files,
> you can not find `mf/lilypond-fonts.conf.in' in the installed files.
> `mf/lilypond-fonts.conf.in' isn't contained in the installed files.
> `font/lilypond-fonts.conf' is contained in the installed files.
> 
> How about this?
> ```
> ; Note that 'LilyPond Serif', 'LilyPond Sans Serif' and 'Lilypond Monospace'
> ; are aliases that are defined in mf/lilypond-fonts.conf.in (source file)
> 
> ; or fonts/lilypond-fonts.conf (installed file).
> ```

Thanks I have now done this.

[trueroad, 2015-07-28 21:44:51]

LGTM
Thank you.

[pkx166h, 2015-08-02 09:13:37]

author	James Lowe <pkx166h@gmail.com>	
	Sun, 26 Jul 2015 08:17:25 +0000 (09:17 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Sun, 2 Aug 2015 09:08:40 +0000 (10:08 +0100)
commit	07756d4f02ceaa6df8e0667bc3313bde61e76abf