[APICHANGE] Fix inconsistent defaults of SES mitigation resolveOptions.

Previously, if the mitigation options were absent (null or undefined
value), the parseFunctionBody option would be taken as true, but if
an options record were provided without the parseFunctionBody property,
it would be taken as false.

Resolved this inconsistency in the direction of parseFunctionBody
defaulting to false.

@ 962c28551fefe6ab6c8c45037fae55254f1459f9

[MarkM, 2015-07-23 19:17:37]

LGTM

https://codereview.appspot.com/257910043/diff/1/src/com/google/caja/ses/start...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/257910043/diff/1/src/com/google/caja/ses/start...
src/com/google/caja/ses/startSES.js:308: if (opt_mitigateOpts === undefined ||
opt_mitigateOpts === null) {
We have (or at least I have) generally said "void 0" rather than "undefined".
Both "void" and "null" are keywords, so we never need to worry about them being
shadowed. (And "void 0" is actually shorter ;).)

[kpreid_google, 2015-07-23 19:20:04]

Previously, if the mitigation options were absent (null or undefined
value), the parseFunctionBody option would be taken as true, but if
an options record were provided without the parseFunctionBody property,
it would be taken as false.

Resolved this inconsistency in the direction of parseFunctionBody
defaulting to false.

[kpreid_google, 2015-07-23 19:21:36]

https://codereview.appspot.com/257910043/diff/1/src/com/google/caja/ses/start...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/257910043/diff/1/src/com/google/caja/ses/start...
src/com/google/caja/ses/startSES.js:308: if (opt_mitigateOpts === undefined ||
opt_mitigateOpts === null) {
On 2015/07/23 19:17:37, MarkM wrote:
> We have (or at least I have) generally said "void 0" rather than "undefined".
> Both "void" and "null" are keywords, so we never need to worry about them
being
> shadowed. (And "void 0" is actually shorter ;).)

I object in principle to this because we are not actually being fully defensive
against shadowing and this practice incorrectly suggests we are attempting it.

However, changed for consistency.

[MarkM, 2015-07-23 19:26:39]

https://codereview.appspot.com/257910043/diff/20001/src/com/google/caja/lang/...
File src/com/google/caja/lang/html/html5-attributes-whitelist.json (left):

https://codereview.appspot.com/257910043/diff/20001/src/com/google/caja/lang/...
src/com/google/caja/lang/html/html5-attributes-whitelist.json:67:
"METER::OPTIMUM",
Why does this line disappear in patch set 2?

https://codereview.appspot.com/257910043/diff/20001/tests/com/google/caja/plu...
File tests/com/google/caja/plugin/test-scan-guest.js (right):

https://codereview.appspot.com/257910043/diff/20001/tests/com/google/caja/plu...
tests/com/google/caja/plugin/test-scan-guest.js:1351: var ctor = window[name];
Did you intend to revert this line?

[kpreid_google, 2015-07-23 19:30:38]

Previously, if the mitigation options were absent (null or undefined
value), the parseFunctionBody option would be taken as true, but if
an options record were provided without the parseFunctionBody property,
it would be taken as false.

Resolved this inconsistency in the direction of parseFunctionBody
defaulting to false.

[kpreid_google, 2015-07-23 19:31:27]

Fixed apparent reverts.

(this is why we need a new workflow script...)

[MarkM, 2015-07-23 19:32:40]

Back to LGTM