Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2178)

Issue 257110043: Update tests/framework/CMakeLists.txt for better test output check

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by zhaoqin
Modified:
8 years, 9 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- Update tests/framework/CMakeLists.txt for better test output check - add -stderr_mask 0xc to clean output - update expect output for each test ---------------

Patch Set 1 #

Total comments: 2

Patch Set 2 : update commit msg #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tests/framework/CMakeLists.txt View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7
zhaoqin
8 years, 9 months ago (2015-07-30 22:45:54 UTC) #1
zhaoqin
https://codereview.appspot.com/257110043/diff/1/tests/framework/CMakeLists.txt File tests/framework/CMakeLists.txt (right): https://codereview.appspot.com/257110043/diff/1/tests/framework/CMakeLists.txt#newcode84 tests/framework/CMakeLists.txt:84: set_tests_properties(${test_name} PROPERTIES PASS_REGULAR_EXPRESSION "${pass_regex}") cannot append $ here. https://codereview.appspot.com/257110043/diff/1/tests/framework/CMakeLists.txt#newcode95 ...
8 years, 9 months ago (2015-07-30 22:51:10 UTC) #2
bruening
On 2015/07/30 22:51:10, zhaoqin wrote: > cannot append $ here. > cannot put ^ at ...
8 years, 9 months ago (2015-07-30 23:04:58 UTC) #3
zhaoqin
On 2015/07/30 23:04:58, bruening wrote: > On 2015/07/30 22:51:10, zhaoqin wrote: > > cannot append ...
8 years, 9 months ago (2015-07-31 03:33:33 UTC) #4
zhaoqin
Commit log for latest patchset: --------------- Update tests/framework/CMakeLists.txt for better test output check - add ...
8 years, 9 months ago (2015-07-31 04:09:57 UTC) #5
bruening
LGTM
8 years, 9 months ago (2015-07-31 15:30:41 UTC) #6
zhaoqin
8 years, 9 months ago (2015-07-31 20:27:14 UTC) #7
Committed as
https://github.com/DynamoRIO/drmemory/commit/3bcefa25abf2295f8dbe3fa912e35c9a...

Final commit log: 
---------------
Update tests/framework/CMakeLists.txt for better test output check

- add -quiet and -stderr_mask 0xc for clean output
- update expected output for each test

Review-URL: https://codereview.appspot.com/257110043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b