Issue 256990043: NR Changing Defaults: document \etc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 256990043: NR Changing Defaults: document \etc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by dak

Modified:
8 years, 7 months ago

Reviewers:
Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

NR Changing Defaults: document \etc Needs issue 4505 as basis, so review consists of two patches, first providing issue 4505, second providing the doc on top.

Patch Set 2 : NR Changing Defaults: document \etc #

Total comments: 3

Patch Set 3 : Trevor's suggestions #

Patch Set 4 : rebase to current master #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	Documentation/notation/changing-defaults.itely	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Trevor Daniels

Apart from nitpicking, doc changes LGTM Trevor https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-defaults.itely#newcode4769 Documentation/notation/changing-defaults.itely:4769: @lilypond[quote,verbatim,ragged-right] padText ...

8 years, 9 months ago (2015-07-26 18:59:22 UTC) #2

dak

https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/256990043/diff/20001/Documentation/notation/changing-defaults.itely#newcode4769 Documentation/notation/changing-defaults.itely:4769: @lilypond[quote,verbatim,ragged-right] padText = On 2015/07/26 18:59:22, Trevor Daniels wrote: ...

8 years, 9 months ago (2015-07-27 07:17:26 UTC) #4

rebase to current master

Expand All Messages | Collapse All Messages