Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(509)

Issue 256790043: Stack traces now capture nested eval info if present. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by MarkM
Modified:
4 years, 4 months ago
Reviewers:
kpreid_google
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

Chrome makes stacktrace info available in structured form through the debugging API, including nested positions for nested eval positions, except for https://code.google.com/p/v8/issues/detail?id=4268 . Before this CL we were not extracting nested eval position info. Now we do, while working around that bug. FF makes stacktrace info available as a string, including nested eval position info. Before this CL, we were scraping this string imperfectly with RegExps, but missing the eval position info. Now we scrape that as well. Before this CL, we were using Causeway's JSON format for representing stack trace structure. But Causeway's format did not anticipate nested eval positions. This CL defines and uses an extended Causeway format that includes room for this info. Enhace the rendering of a Causeway stack into a v8-like stack trace string to also render the nested eval positions of the extended Causeway format. Adds a confineLater to go with compileExprLater, by analogy to confine and compileExpr. Revise explicit.html to show these enhanced stacktraces, while also showing more cases of eval strings that are and are not annotated with source position info.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Stack traces now capture nested eval info if present. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -228 lines) Patch
M src/com/google/caja/ses/compileExprLater.js View 3 chunks +40 lines, -16 lines 0 comments Download
M src/com/google/caja/ses/debug.js View 1 6 chunks +277 lines, -145 lines 0 comments Download
M src/com/google/caja/ses/explicit.html View 3 chunks +50 lines, -24 lines 0 comments Download
M src/com/google/caja/ses/useHTMLLogger.js View 3 chunks +64 lines, -43 lines 0 comments Download

Messages

Total messages: 6
MarkM
4 years, 5 months ago (2015-07-12 03:04:22 UTC) #1
kpreid_google
https://codereview.appspot.com/256790043/diff/1/src/com/google/caja/ses/debug.js File src/com/google/caja/ses/debug.js (right): https://codereview.appspot.com/256790043/diff/1/src/com/google/caja/ses/debug.js#newcode129 src/com/google/caja/ses/debug.js:129: var line2CWFrame = (function() { Add a doc comment ...
4 years, 4 months ago (2015-07-20 16:34:44 UTC) #2
MarkM
Chrome makes stacktrace info available in structured for through the debugging API, including nested positions ...
4 years, 4 months ago (2015-07-20 22:18:59 UTC) #3
MarkM
https://codereview.appspot.com/256790043/diff/1/src/com/google/caja/ses/debug.js File src/com/google/caja/ses/debug.js (right): https://codereview.appspot.com/256790043/diff/1/src/com/google/caja/ses/debug.js#newcode129 src/com/google/caja/ses/debug.js:129: var line2CWFrame = (function() { On 2015/07/20 16:34:43, kpreid_google ...
4 years, 4 months ago (2015-07-20 22:20:48 UTC) #4
kpreid_google
LGTM
4 years, 4 months ago (2015-07-20 22:43:32 UTC) #5
MarkM
4 years, 4 months ago (2015-07-23 19:18:43 UTC) #6
at 6774ff211039c6ca84e6c4111ed2384b43fc4abd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b