Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2003)

Issue 256070043: Fix 'o' keyboard shortcut on dashboard page.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by twifkak
Modified:
8 years, 8 months ago
CC:
codereview-list_googlegroups.com
Visibility:
Public.

Description

Fix 'o' keyboard shortcut on dashboard page.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M static/script.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15
twifkak
8 years, 8 months ago (2015-07-20 19:19:27 UTC) #1
twifkak
This is related to this pull request: https://github.com/rietveld-codereview/rietveld/pull/526 It's not clear from the instructions at ...
8 years, 8 months ago (2015-07-20 19:25:29 UTC) #2
twifkak
On 2015/07/20 19:25:29, twifkak wrote: > This is related to this pull request: > https://github.com/rietveld-codereview/rietveld/pull/526 ...
8 years, 8 months ago (2015-07-20 20:00:21 UTC) #3
twifkak
+albrecht.andi@gmail.com Andi: Ping. Is this the right place to email for code reviews?
8 years, 8 months ago (2015-07-30 00:52:36 UTC) #4
twifkak
+jrobbins (corp)
8 years, 8 months ago (2015-07-30 00:59:56 UTC) #5
jrobbins (corp)
lgtm This change looks like a good fix. I'm not going to commit it or ...
8 years, 8 months ago (2015-07-30 15:40:05 UTC) #6
twifkak
On 2015/07/30 15:40:05, jrobbins (corp) wrote: > lgtm > > This change looks like a ...
8 years, 8 months ago (2015-07-30 16:17:56 UTC) #7
jrobbins (corp)
I see that there is some activity on https://groups.google.com/forum/#!forum/codereview-discuss I think you were right to ...
8 years, 8 months ago (2015-07-30 16:33:07 UTC) #8
Andi
Hi, sorry for the (very) late reply! The pull request is merged now. Thanks a ...
8 years, 8 months ago (2015-07-30 18:39:58 UTC) #9
twifkak
No problem, thanks for the any reply. :) I have no clue, but I'll ask ...
8 years, 8 months ago (2015-07-30 19:18:37 UTC) #10
jrobbins (corp)
On Thu, Jul 30, 2015 at 11:39 AM, Andi Albrecht <albrecht.andi@gmail.com> wrote: > > Is ...
8 years, 8 months ago (2015-07-30 19:19:04 UTC) #11
twifkak
On Thu, Jul 30, 2015 at 12:19 PM, Jason Robbins <jrobbins@google.com> wrote: > However, I ...
8 years, 8 months ago (2015-07-30 19:23:17 UTC) #12
twifkak
(and deployed to codereview.chromium.org) On Thu, Jul 30, 2015 at 12:22 PM, Devin Mullins <twifkak@google.com> ...
8 years, 8 months ago (2015-07-30 19:23:42 UTC) #13
jrobbins (corp)
On Thu, Jul 30, 2015 at 12:23 PM, Devin Mullins <twifkak@google.com> wrote: > (and deployed ...
8 years, 8 months ago (2015-07-30 21:14:12 UTC) #14
Andi
8 years, 8 months ago (2015-07-31 07:40:34 UTC) #15
The instance on codereview.appspot.com is now up-to-date.

Thanks again for the fix!


Jason Robbins <jrobbins@google.com> schrieb am Do., 30. Juli 2015 um
23:14 Uhr:

> On Thu, Jul 30, 2015 at 12:23 PM, Devin Mullins <twifkak@google.com>
> wrote:
>
>> (and deployed to codereview.chromium.org)
>>
>
> I just wrote a CL to make the same change in that fork.
>
> I usually deploy new versions to codereview.chromium.org weekly on
> Mondays.
>

ah, good to know! I was a bit puzzled what happened to the chromium
branch/instance after the migration to github because it was so quiet.

--
Andi


>
> Thanks,
> jason!
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b