Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(253)

Issue 255850043: Rewrite chrome_test_utils (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by benjhayden
Modified:
8 years, 9 months ago
CC:
tracing-review_chromium.org
Base URL:
git@github.com:google/trace-viewer@master
Visibility:
Public.

Description

Rewrite chrome_test_utils. audits.addInputEvent() creates modern-style InputLatency events, so RAILIRFinder must be updated to use typeName even though it's about to be rewritten by https://codereview.appspot.com/248740043/ R=dsinclair@chromium.org, nduca@google.com Committed: https://chromium.googlesource.com/external/trace-viewer/+/d174f17ed8c80cd89c1c2eec3a1c0a4c9bad3283

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : s/cat/category/g #

Patch Set 3 : comments #

Total comments: 2

Patch Set 4 : comments #

Patch Set 5 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -86 lines) Patch
M tracing/tracing/extras/chrome/chrome_browser_helper.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/extras/chrome/chrome_browser_helper_test.html View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M tracing/tracing/extras/chrome/chrome_test_utils.html View 1 2 3 1 chunk +8 lines, -39 lines 0 comments Download
M tracing/tracing/extras/rail/rail_ir_finder.html View 2 chunks +17 lines, -16 lines 0 comments Download
M tracing/tracing/extras/rail/rail_ir_finder_test.html View 1 2 8 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 8
benjhayden
PTAL
8 years, 10 months ago (2015-07-08 17:42:17 UTC) #1
dsinclair
https://codereview.appspot.com/255850043/diff/40001/tracing/tracing/model/async_slice.html File tracing/tracing/model/async_slice.html (right): https://codereview.appspot.com/255850043/diff/40001/tracing/tracing/model/async_slice.html#newcode32 tracing/tracing/model/async_slice.html:32: this.cat = this.category; // TODO(benjhayden): Deprecate? This seems like ...
8 years, 10 months ago (2015-07-08 19:33:45 UTC) #2
benjhayden
https://codereview.appspot.com/255850043/diff/40001/tracing/tracing/model/async_slice.html File tracing/tracing/model/async_slice.html (right): https://codereview.appspot.com/255850043/diff/40001/tracing/tracing/model/async_slice.html#newcode32 tracing/tracing/model/async_slice.html:32: this.cat = this.category; // TODO(benjhayden): Deprecate? On 2015/07/08 19:33:44, ...
8 years, 10 months ago (2015-07-08 20:25:30 UTC) #3
benjhayden
PTAL
8 years, 9 months ago (2015-07-20 23:26:51 UTC) #4
nduca(google)
seems fine lgtm was dan okay with the patch? https://codereview.appspot.com/255850043/diff/100001/tracing/tracing/extras/chrome/chrome_test_utils.html File tracing/tracing/extras/chrome/chrome_test_utils.html (right): https://codereview.appspot.com/255850043/diff/100001/tracing/tracing/extras/chrome/chrome_test_utils.html#newcode39 tracing/tracing/extras/chrome/chrome_test_utils.html:39: ...
8 years, 9 months ago (2015-07-20 23:31:39 UTC) #5
benjhayden
I'll wait for Dan. Thanks! https://codereview.appspot.com/255850043/diff/100001/tracing/tracing/extras/chrome/chrome_test_utils.html File tracing/tracing/extras/chrome/chrome_test_utils.html (right): https://codereview.appspot.com/255850043/diff/100001/tracing/tracing/extras/chrome/chrome_test_utils.html#newcode39 tracing/tracing/extras/chrome/chrome_test_utils.html:39: function addEvent(thread, dict) { ...
8 years, 9 months ago (2015-07-20 23:42:02 UTC) #6
dsinclair
lgtm. Please set or remove the BUG= line before committing.
8 years, 9 months ago (2015-07-21 14:31:26 UTC) #7
benjhayden
8 years, 9 months ago (2015-07-21 18:37:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:140001) manually as
d174f17ed8c80cd89c1c2eec3a1c0a4c9bad3283 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b