Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1408)

Issue 25460045: instance container method tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by thumper
Modified:
6 years ago
Reviewers:
mp+194975, wallyworld
Visibility:
Public.

Description

instance container method tests Be explicit in the container type equality. Test the parsing of KVM. Change the tests names to be consistent with the functions. https://code.launchpad.net/~thumper/juju-core/better-container-instance-tests/+merge/194975 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M instance/container_test.go View 1 chunk +22 lines, -6 lines 0 comments Download

Messages

Total messages: 2
thumper
Please take a look.
6 years ago (2013-11-13 03:02:24 UTC) #1
wallyworld
6 years ago (2013-11-13 03:38:56 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b