Issue 2543041: Fixes issue 1283.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2543041: Fixes issue 1283. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by metaweta

Modified:
15 years, 8 months ago

Reviewers:
Mark S. Miller, Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Adds a getter property to Object.prototype that returns the 'constructor' property on 'this'. The other alternative would be reimplementing the triangle of hackery for new___ so that after an object is constructed we can whitelist its constructor property.

Patch Set 1 #

Patch Set 2 : Fixes issue 1283. #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	src/com/google/caja/es53.js	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

metaweta

This includes the change for 1285; I'll snapshot this one once that's in.

15 years, 8 months ago (2010-10-16 02:07:06 UTC) #2

Mark S. Miller

See comment #2 at http://code.google.com/p/google-caja/issues/detail?id=1283#c2

15 years, 8 months ago (2010-10-16 02:24:33 UTC) #3

LGTM

Expand All Messages | Collapse All Messages