Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(144)

Issue 2543041: Fixes issue 1283. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by metaweta
Modified:
15 years, 8 months ago
Reviewers:
Mark S. Miller, Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adds a getter property to Object.prototype that returns the 'constructor' property on 'this'. The other alternative would be reimplementing the triangle of hackery for new___ so that after an object is constructed we can whitelist its constructor property.

Patch Set 1 #

Patch Set 2 : Fixes issue 1283. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/com/google/caja/es53.js View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
metaweta
15 years, 8 months ago (2010-10-16 01:46:39 UTC) #1
metaweta
This includes the change for 1285; I'll snapshot this one once that's in.
15 years, 8 months ago (2010-10-16 02:07:06 UTC) #2
Mark S. Miller
See comment #2 at http://code.google.com/p/google-caja/issues/detail?id=1283#c2
15 years, 8 months ago (2010-10-16 02:24:33 UTC) #3
metaweta
I removed the changes from 1285.
15 years, 8 months ago (2010-10-16 03:56:33 UTC) #4
Jasvir
15 years, 8 months ago (2010-10-18 18:14:41 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b