Error on juju-gui in the bundle services

Error on juju-gui in the bundle services

Quickstart should fail if there is an instance of juju-gui in the services, because that will lead to a name conflict when deploying the bundle.

To test: `make check`

To QA: `.venv/bin/python juju-quickstart https://gist.github.com/makyo/7435270/raw/6f0d5ff910dd1a82b97c7170915a196381b2b146/bundle.yaml` should fail with a message explaining that juju-gui should be removed from the bundle; other bundles will still succeed.

https://code.launchpad.net/~makyo/juju-quickstart/no-gui-in-bundle/+merge/194907

(do not edit description out of merge proposal)

[matthew.scott, 2013-11-12 17:49:58]

Please take a look.

[bac, 2013-11-12 18:11:47]

LGTM with small change and QA-OK

https://codereview.appspot.com/25340043/diff/1/quickstart/utils.py
File quickstart/utils.py (right):

https://codereview.appspot.com/25340043/diff/1/quickstart/utils.py#newcode155
quickstart/utils.py:155: raise ValueError('bundle {} contains an instance of
juju-gui. '
Would be more readable with quotes around the bundle name in the error output.

[matthew.scott, 2013-11-12 19:14:18]

Thanks for the review!

https://codereview.appspot.com/25340043/diff/1/quickstart/utils.py
File quickstart/utils.py (right):

https://codereview.appspot.com/25340043/diff/1/quickstart/utils.py#newcode155
quickstart/utils.py:155: raise ValueError('bundle {} contains an instance of
juju-gui. '
On 2013/11/12 18:11:47, bac wrote:
> Would be more readable with quotes around the bundle name in the error output.

I agree. Would like to defer until we can get all, however.  I started in on
this but there are ramifications all throughout the project.

[matthew.scott, 2013-11-12 20:32:45]

*** Submitted:

Error on juju-gui in the bundle services

Quickstart should fail if there is an instance of juju-gui in the services,
because that will lead to a name conflict when deploying the bundle.

To test: `make check`

To QA: `.venv/bin/python juju-quickstart
https://gist.github.com/makyo/7435270/raw/6f0d5ff910dd1a82b97c7170915a196381b...
should fail with a message explaining that juju-gui should be removed from the
bundle; other bundles will still succeed.

R=bac
CC=
https://codereview.appspot.com/25340043