Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1216)

Issue 252230043: Tie: add some C++ rigor and concision (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by Dan Eble
Modified:
8 years, 8 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

I wanted to see how Tie would look with instance methods instead of static methods. I'm looking forward to hearing your opinions. I recommend starting with tie.hh. There is no tracker for this. It's not fully baked and it won't apply to master anyway.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -67 lines) Patch
M lily/accidental-engraver.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M lily/completion-note-heads-engraver.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M lily/include/tie.hh View 1 chunk +21 lines, -7 lines 0 comments Download
M lily/include/tie-column.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/tie.cc View 9 chunks +33 lines, -32 lines 0 comments Download
M lily/tie-column.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M lily/tie-engraver.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M lily/tie-formatting-problem.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M lily/tie-specification.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Dan Eble
8 years, 10 months ago (2015-07-15 02:35:48 UTC) #1
dak
nine.fierce.ballads@gmail.com writes: > Reviewers: , > > Description: > I wanted to see how Tie ...
8 years, 10 months ago (2015-07-15 04:54:02 UTC) #2
dak
8 years, 10 months ago (2015-07-15 06:03:38 UTC) #3
David Kastrup <dak@gnu.org> writes:

> nine.fierce.ballads@gmail.com writes:
>
>> Reviewers: ,
>>
>> Description:
>> I wanted to see how Tie would look with instance methods instead of
>> static methods.  I'm looking forward to hearing your opinions.
>
> Here's a script in progress that currently does way, way too much.

While I am at it, I should likely include the patches leading up to
this.  Commit messages leave something to be desired...

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b